Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][NFC] Unify naming scheme for SYCL workflows. #12525

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[CI][NFC] Unify naming scheme for SYCL workflows. #12525

merged 2 commits into from
Jan 31, 2024

Conversation

bader
Copy link
Contributor

@bader bader commented Jan 29, 2024 •
edited
Loading

All GitHub Actions workflows added by project follow similar naming notation:

  1. Name starts with sycl prefix.
  2. Use dash - instead of underscore _ to separate words.

@bader
[CI][NFC] Unify naming scheme for SYCL workflows.
95a8aa3 
All GitHub Actions worflows added by project follow similar naming
notation:
1. Name starts with `sycl_` prefix.
2. Use underscore `_` instead of dash `-` to separate words.

This patches fixes naming of two workflows which do not follow this
notion.
@bader bader requested a review from a team as a code owner January 29, 2024 19:17
@bader
Copy link
Contributor Author

bader commented Jan 29, 2024

2. Use underscore _ instead of dash - to separate words.

@intel/dpcpp-devops-reviewers, I think we should switch to using - instead of _. The reasons are: LLVM project uses - and it's easier to type. Are you okay if we make this change for within this PR?

@bader
Copy link
Contributor Author

bader commented Jan 30, 2024

@intel/dpcpp-devops-reviewers, ping.

@steffenlarsen
Copy link
Contributor

  1. Use underscore _ instead of dash - to separate words.

@intel/dpcpp-devops-reviewers, I think we should switch to using - instead of _. The reasons are: LLVM project uses - and it's easier to type. Are you okay if we make this change for within this PR?

No objections from me. Seems like a small price to pay for unification with upstream.

@bader bader merged commit 16a368c into intel:sycl Jan 31, 2024
7 checks passed
@bader bader deleted the gha-workflow-naming branch January 31, 2024 19:20
bader added a commit that referenced this pull request Jan 31, 2024
@bader
Revert "[CI][NFC] Unify naming scheme for SYCL workflows. (#12525)"
d3974a8 
This reverts commit 16a368c.
@bader bader mentioned this pull request Jan 31, 2024
Merged
bader added a commit that referenced this pull request Jan 31, 2024
@bader
Revert "[CI][NFC] Unify naming scheme for SYCL workflows." (#12567)
1b5daa8 
Reverts #12525

In addition to file renaming, we need to update file names referenced
inside the workflow files.
@bader bader restored the gha-workflow-naming branch January 31, 2024 19:25
@bader bader mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bader @steffenlarsen