Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Try to make OCL CPU task work on Intel GEN12 runner in Nightly #12608

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[CI] Try to make OCL CPU task work on Intel GEN12 runner in Nightly #12608

merged 1 commit into from
Feb 5, 2024

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Feb 5, 2024 •
edited
Loading

Being tested in https://github.com/intel/llvm/actions/runs/7788342464.

@aelovikov-intel aelovikov-intel marked this pull request as ready for review February 5, 2024 17:43
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner February 5, 2024 17:43
steffenlarsen
steffenlarsen approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have the safety measures in place to make this somewhat safe. Let's do it.

@aelovikov-intel
Copy link
Contributor Author

https://github.com/intel/llvm/actions/runs/7788342464/job/21237991635 shows the fix worked, the rest of the testing is unrelated to the change.

@aelovikov-intel aelovikov-intel merged commit 62c86d7 into sycl Feb 5, 2024
17 of 20 checks passed
@aelovikov-intel aelovikov-intel deleted the ocl-cpu-nightly-gen12 branch February 5, 2024 17:52
@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Feb 5, 2024 •
edited
Loading

Post commit failures:

L0 on Intel GEN12 GPU:

Failed Tests (1):
  SYCL :: ESIMD/dword_local_accessor_atomic_smoke.cpp

@intel/dpcpp-esimd-reviewers , does this look familiar?

FAIL: SYCL :: ESIMD/dword_local_accessor_atomic_smoke.cpp (541 of 1870)
******************** TEST 'SYCL :: ESIMD/dword_local_accessor_atomic_smoke.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 11
/__w/llvm/llvm/toolchain/bin//clang++   -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/dword_local_accessor_atomic_smoke.cpp -o /__w/llvm/llvm/build-e2e/ESIMD/Output/dword_local_accessor_atomic_smoke.cpp.tmp.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/dword_local_accessor_atomic_smoke.cpp -o /__w/llvm/llvm/build-e2e/ESIMD/Output/dword_local_accessor_atomic_smoke.cpp.tmp.out
# note: command had no output on stdout or stderr
# RUN: at line 12
env ONEAPI_DEVICE_SELECTOR=level_zero:gpu  /__w/llvm/llvm/build-e2e/ESIMD/Output/dword_local_accessor_atomic_smoke.cpp.tmp.out
# executed command: env ONEAPI_DEVICE_SELECTOR=level_zero:gpu /__w/llvm/llvm/build-e2e/ESIMD/Output/dword_local_accessor_atomic_smoke.cpp.tmp.out
# .---command stdout------------
# | Running on Intel(R) Iris(R) Xe Graphics
# |  Local accessor Testing mode=DWORD op=inc T=int32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=inc T=uint32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=inc T=int32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=inc T=uint32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=dec T=int32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=dec T=uint32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=dec T=int32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=dec T=uint32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=add T=int32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=add T=uint32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=add T=int32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=add T=uint32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=sub T=int32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=sub T=uint32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=sub T=int32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=sub T=uint32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=smax T=int32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=smax T=int32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=smin T=int32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=smin T=int32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=umax T=uint32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=umax T=uint32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=umin T=uint32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }...
# |   failed at index 0: 2 != 0(gold)
# |   FAILED
# |   pass rate: 0% (0/1)
# |  Local accessor Testing mode=DWORD op=umin T=uint32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=load T=int32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=load T=uint32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=load T=int32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=load T=uint32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=load T=float N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=load T=float N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=store T=int32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=store T=uint32_t N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=store T=int32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=store T=uint32_t N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=store T=float N=1
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# |  Local accessor Testing mode=DWORD op=store T=float N=8
# | 	{ thr_per_group=8 n_groups=1 start_ind=0 masked_lane=1 repeat=1 stride=1 }... passed
# | FAILED
# `-----------------------------
# error: command failed with exit status: 1

L0 on Intel Arc GPU:

Failed Tests (1):
  SYCL :: OneapiDeviceSelector/case_sensitivity.cpp

FAIL: SYCL :: OneapiDeviceSelector/case_sensitivity.cpp (1427 of 1870)
******************** TEST 'SYCL :: OneapiDeviceSelector/case_sensitivity.cpp' FAILED ********************
Exit Code: -11

Command Output (stdout):
--
# RUN: at line 4
/__w/llvm/llvm/toolchain/bin//clang++   -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/OneapiDeviceSelector/Inputs/trivial.cpp -o /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/OneapiDeviceSelector/Inputs/trivial.cpp -o /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# note: command had no output on stdout or stderr
# RUN: at line 5
env ONEAPI_DEVICE_SELECTOR="OPENCL:*"  /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# executed command: env 'ONEAPI_DEVICE_SELECTOR=OPENCL:*' /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# .---command stdout------------
# | Device: Intel(R) Arc(TM) A750 Graphics
# | Device: Intel(R) UHD Graphics 770
# | Device: 12th Gen Intel(R) Core(TM) i9-12900
# | Device: Intel(R) FPGA Emulation Device
# `-----------------------------
# RUN: at line 6
env ONEAPI_DEVICE_SELECTOR="opencl:*"  /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# executed command: env 'ONEAPI_DEVICE_SELECTOR=opencl:*' /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# .---command stdout------------
# | Device: Intel(R) Arc(TM) A750 Graphics
# | Device: Intel(R) UHD Graphics 770
# | Device: 12th Gen Intel(R) Core(TM) i9-12900
# | Device: Intel(R) FPGA Emulation Device
# `-----------------------------
# RUN: at line 7
env ONEAPI_DEVICE_SELECTOR="*:GPU"  /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# executed command: env 'ONEAPI_DEVICE_SELECTOR=*:GPU' /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# .---command stdout------------
# | Device: Intel(R) Arc(TM) A750 Graphics
# | Device: Intel(R) UHD Graphics 770
# | Device: Intel(R) Arc(TM) A750 Graphics
# | Device: Intel(R) UHD Graphics 770
# `-----------------------------
# RUN: at line 8
env ONEAPI_DEVICE_SELECTOR="*:gpu"  /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# executed command: env 'ONEAPI_DEVICE_SELECTOR=*:gpu' /__w/llvm/llvm/build-e2e/OneapiDeviceSelector/Output/case_sensitivity.cpp.tmp.out
# .---command stdout------------
# | Device: Intel(R) Arc(TM) A750 Graphics
# | Device: Intel(R) UHD Graphics 770
# | Device: Intel(R) Arc(TM) A750 Graphics
# | Device: Intel(R) UHD Graphics 770
# `-----------------------------
# error: command failed with exit status: -11

@aelovikov-intel
Copy link
Contributor Author

The failures can't be related to this PR as it only changed SYCL Nightly workflow. That said, I can't think of some explanation at this moment.

@sarnex
Copy link
Contributor

sarnex commented Feb 5, 2024 •
edited
Loading

I think dword_local_accessor_atomic_smoke.cpp started running with the recent driver update, probably it sporadically fails.
If it fails again let's make it unsupported and make an internal ticket

@aelovikov-intel aelovikov-intel mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelovikov-intel @sarnex @steffenlarsen