Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Skip Graph tests based on sycl-ls output #12812

Merged
merged 7 commits into from
Mar 11, 2024

Commits on Mar 4, 2024

  1. [SYCL][Graph] Skip Graph tests based on sycl-ls output

    The graph extension tests are currently skipped during execution
    for devices which don't support the graphs extension. However,
    this early return causes the tests to be reported as passed and
    makes it hard from looking at the results to know if the tests
    actually stressed the graphs code or not.
    
    Improved this situation by modifying `sycl-ls --verbose` to output
    the `sycl_ext_oneapi_graph` string
    when a device supports the graph extension. We can then use this to
    inform the LIT config and set a requirement for the `graph-extension`
    feature in the tests, similar to what is done for aspects. This enables the
    tests to be obviously skipped for devices that don't support graphs.
    
    To enable setting this requirement in `lit.local.cfg` files some extra
    directories have been created, in particular `UnsupportedDevice` which
    doesn't have a requirement on `graph-extension` as the tests verify
    expected behaviour with unsupported devices.
    EwanC committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8b7e2dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e00170 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    db01268 View commit details
    Browse the repository at this point in the history
  4. Change device info query to aspect

    Based on DPC++ maintainer feedback that an aspect is
    more useful for sycl-ls and lit testing. Our emulation
    mode has also never been implemented.
    EwanC committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    49968e8 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Refine aspect description

    Also check for OpenCL backend support for
    `cl_khr_command_buffer` when determining if
    SYCL-Graphs support should be reported.
    EwanC committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    db1d01b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a616cfa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    59c5600 View commit details
    Browse the repository at this point in the history