[SYCL][Graph] Skip Graph tests based on sycl-ls output #12812
Conversation
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
force-pushed
the
ewan/sycl-ls_graphs
branch
from
0059d02
to
4039f62
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Hint. Here is an example: https://github.com/intel/llvm/blob/sycl/clang/test/Interpreter/CUDA/lit.local.cfg. All tests from clang/test/Interpreter/CUDA/ directory are skipped if host doesn't support CUDA. |
EwanC
force-pushed
the
ewan/sycl-ls_graphs
branch
from
4039f62
to
f10cb86
Compare
EwanC
force-pushed
the
ewan/sycl-ls_graphs
branch
from
fa5a111
to
2005d26
Compare
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
EwanC
force-pushed
the
ewan/sycl-ls_graphs
branch
from
2005d26
to
823a3e9
Compare
|
@intel/llvm-reviewers-runtime Could I get a review on this please |
There was a problem hiding this comment.
Changes LGTM! Since it is now a change to the extension however, I would like @reble, @Bensuo, and/or @mfrancepillois to re-approve it.
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
Also check for OpenCL backend support for `cl_khr_command_buffer` when determining if SYCL-Graphs support should be reported.
EwanC
force-pushed
the
ewan/sycl-ls_graphs
branch
from
e519ebf
to
a616cfa
Compare
|
ping @intel/dpcpp-tools-reviewers for review |
|
@AlexeySachkov @sarnex @MrSidims Could one of you review on behalf of @intel/dpcpp-tools-reviewers please |
|
@intel/llvm-gatekeepers This is good to merge now |
The graph extension tests are currently skipped during execution for devices which don't support the graphs extension. However, this early return causes the tests to be reported as passed and makes it hard from looking at the results to know if the tests actually stressed the graphs code or not.
Improved this situation by changing the SYCL-Graph device info query to an aspect such that
sycl-ls --verbosewill outputext_oneapi_graphfor supported devices. This can then be used to inform the LIT config and set a requirement for tests, enabling the tests to be obviously skipped for devices that don't support graphs.To enable setting this requirement in
lit.local.cfgfiles some extra directories have been created, in particularUnsupportedDevicewhich contains tests that don't have a requirement as the tests verify expected errors are thrown when using the graphs API with unsupported devices.The removal of the device info query means that we can no longer report if a device emulates support for SYCL-Graph, however we currently have no such implementations as they haven't yet deemed to provide enough value. This is technically an ABI breaking change however due to the removal of symbols, but SYCL-Graph is currently an experimental extension so such changes may be permitted.