Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][COMPAT] nd_range barriers seq_cst by default in supported devices #12974

Merged

Conversation

Alcpz
Copy link
Contributor

@Alcpz Alcpz commented Mar 11, 2024

AMD and CUDA devices still not supported.
CUDA to be supported in #12516

Edit: Since #12516 has been merged, CUDA is also seq_cst by default.

@Alcpz Alcpz requested a review from a team as a code owner March 11, 2024 14:41
@Alcpz Alcpz force-pushed the Alcpz/util-headers-update-nd-range-barrier branch from 43c9239 to 1d8aaa4 Compare April 9, 2024 12:57
@Alcpz Alcpz closed this Apr 11, 2024
@Alcpz Alcpz reopened this Apr 11, 2024
Copy link
Contributor

@joeatodd joeatodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good 👍 Depending what you think about the TODO thing, we should add that, or create a ticket. 🚢

sycl/doc/syclcompat/README.md Show resolved Hide resolved
@Alcpz Alcpz force-pushed the Alcpz/util-headers-update-nd-range-barrier branch from a4df687 to 5aee6e0 Compare April 29, 2024 11:51
@Alcpz
Copy link
Contributor Author

Alcpz commented Apr 29, 2024

@intel/llvm-gatekeepers This is ready for merge. Thanks

@sommerlukas sommerlukas merged commit 9d1cbc5 into intel:sycl Apr 30, 2024
13 checks passed
@Alcpz Alcpz deleted the Alcpz/util-headers-update-nd-range-barrier branch June 3, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants