[Driver][SYCL] Address issue with improper bundler call with -fsycl-link #13002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial change to modify -fsycl-link for AOT introduced a modification to the general toolchain flow that is more aligned with the host link step. This caused a disconnect with the unbundling step from objects where we were unbundling for host and target, but not providing the needed output files. Fix this up to allow for both the host and target output files to be available. There is an additional fix that will be needed to restrict this (i.e. only unbundle the target, and not the host), but functionally what we have in place takes care of the immediate problem at hand.
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sarnex
approved these changes
Mar 19, 2024
hchilama
approved these changes
Mar 19, 2024
|
@intel/llvm-gatekeepers, this one looks ready to merge, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial change to modify -fsycl-link for AOT introduced a modification to the general toolchain flow that is more aligned with the host link step. This caused a disconnect with the unbundling step from objects where we were unbundling for host and target, but not providing the needed output files.
Fix this up to allow for both the host and target output files to be available. There is an additional fix that will be needed to restrict this (i.e. only unbundle the target, and not the host), but functionally what we have in place takes care of the immediate problem at hand.