[SYCL][Graph][HIP] Set minimum ROCm version for graphs #13035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/graph_rocm_ver
branch
from
0d1f318
to
14c0343
Compare
EwanC
force-pushed
the
ewan/graph_rocm_ver
branch
from
14c0343
to
c54779a
Compare
Bensuo
approved these changes
Mar 20, 2024
Tests UR PR oneapi-src/unified-runtime#1447 that only reports support for UR command-buffers on ROCm 5.5.1 and later to work around HIP driver bugs related to HIP-Graph in earlier version. This requirement is also explicitly mentioned in the design doc.
EwanC
force-pushed
the
ewan/graph_rocm_ver
branch
from
c54779a
to
c1b4d1f
Compare
aarongreig
approved these changes
Mar 21, 2024
|
@intel/llvm-gatekeepers please merge |
kbenzie
pushed a commit
to kbenzie/llvm
that referenced
this pull request
Apr 16, 2024
Tests UR PR oneapi-src/unified-runtime#1447 that only reports support for UR command-buffers on ROCm 5.5.1 and later to work around HIP driver bugs related to HIP-Graph in earlier version. This requirement is also explicitly mentioned in the design doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests UR PR oneapi-src/unified-runtime#1447 that only reports support for UR command-buffers on ROCm 5.5.1 and later to work around HIP driver bugs related to HIP-Graph in earlier version.
This requirement is also explicitly mentioned in the design doc.