[HIP][CMDBUF] Require ROCm 5.5.1 for HIP command-buffers #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1447 +/- ##
==========================================
- Coverage 14.82% 12.43% -2.40%
==========================================
Files 250 241 -9
Lines 36220 36242 +22
Branches 4094 4111 +17
==========================================
- Hits 5369 4506 -863
- Misses 30800 31732 +932
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
Bensuo
approved these changes
Mar 18, 2024
JackAKirk
requested changes
Mar 18, 2024
JackAKirk
approved these changes
Mar 19, 2024
An issue using the command-buffer experimental feature was discovered using HIP version 5.4.3 - ROCm/HIP#2450 Set the minimum supported version as ROCm 5.5.1 to avoid this bug, as this is the next ROCm available version after 5.4.3 we have have available for testing and can confirm passes the SYCL-Graph tests. Note: The ROCm version tested by DPC++ GitHub CI is currently 6.0.0.
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Mar 21, 2024
Tests UR PR oneapi-src/unified-runtime#1447 that only reports support for UR command-buffers on ROCm 5.5.1 and later to work around HIP driver bugs related to HIP-Graph in earlier version. This requirement is also explicitly mentioned in the design doc.
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Mar 21, 2024
Tests UR PR oneapi-src/unified-runtime#1447 that only reports support for UR command-buffers on ROCm 5.5.1 and later to work around HIP driver bugs related to HIP-Graph in earlier version. This requirement is also explicitly mentioned in the design doc.
kbenzie
pushed a commit
to kbenzie/llvm
that referenced
this pull request
Apr 16, 2024
Tests UR PR oneapi-src/unified-runtime#1447 that only reports support for UR command-buffers on ROCm 5.5.1 and later to work around HIP driver bugs related to HIP-Graph in earlier version. This requirement is also explicitly mentioned in the design doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue using the command-buffer experimental feature was discovered using HIP version 5.4.3 - ROCm/HIP#2450
Set the minimum supported version as ROCm 5.5.1 to avoid this bug, as this is the next ROCm available version after 5.4.3 we have have available for testing and can confirm passes the SYCL-Graph tests.
DPC++ PR intel/llvm#13035, note that the ROCm version tested by DPC++ GitHub CI is currently 6.0.0.