Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Use std::array as storage for syc::vec on device #13270

Closed
wants to merge 90 commits into from
Closed

[SYCL] Use std::array as storage for syc::vec on device #13270

wants to merge 90 commits into from

Commits on Mar 29, 2024

  1. Made preview-breaking-changes default

    @uditagarwal97
    uditagarwal97 committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    2b2a3d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Initial cleanup

    @uditagarwal97
    uditagarwal97 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    459e66d View commit details
    Browse the repository at this point in the history

  2. Merge origin/sycl

    @uditagarwal97
    uditagarwal97 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    fd09190 View commit details
    Browse the repository at this point in the history

  3. Fix

    @uditagarwal97
    uditagarwal97 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    7065472 View commit details
    Browse the repository at this point in the history

  4. Delete sycl/test_bfloat.cpp

    @uditagarwal97
    uditagarwal97 authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    0ca00e2 View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @uditagarwal97
    uditagarwal97 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    b3881f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Cleanup

    @uditagarwal97
    uditagarwal97 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    d77d537 View commit details
    Browse the repository at this point in the history

  2. More cleanup

    @uditagarwal97
    uditagarwal97 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1fe41c2 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Fix failures

    @uditagarwal97
    uditagarwal97 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    a75a93b View commit details
    Browse the repository at this point in the history

  2. Fiox formatting

    @uditagarwal97
    uditagarwal97 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c78b57d View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Add a test for checking dveice code.

    @uditagarwal97
    uditagarwal97 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ca85863 View commit details
    Browse the repository at this point in the history

  2. Fix formating

    @uditagarwal97
    uditagarwal97 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8af05a2 View commit details
    Browse the repository at this point in the history

  3. Fix test

    @uditagarwal97
    uditagarwal97 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c1763a0 View commit details
    Browse the repository at this point in the history

  4. Remove HostHalf

    @uditagarwal97
    uditagarwal97 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    209e9f0 View commit details
    Browse the repository at this point in the history

  5. Adress reviews

    @uditagarwal97
    uditagarwal97 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    4cda13a View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Fix failures

    @uditagarwal97
    uditagarwal97 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    91301c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Fix

    @uditagarwal97
    uditagarwal97 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7305e3b View commit details
    Browse the repository at this point in the history

  2. Fix formatting and device code check test case.

    @uditagarwal97
    uditagarwal97 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f8840c2 View commit details
    Browse the repository at this point in the history

  3. Fix formatting

    @uditagarwal97
    uditagarwal97 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ea6f828 View commit details
    Browse the repository at this point in the history

  4. More formatting

    @uditagarwal97
    uditagarwal97 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    686b9fc View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge remote-tracking branch 'origin/sycl' into vector-refac

    @uditagarwal97
    uditagarwal97 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4fb6456 View commit details
    Browse the repository at this point in the history

  2. Remove comments

    @uditagarwal97
    uditagarwal97 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    7af74da View commit details
    Browse the repository at this point in the history

  3. Fix SYCL-CTS

    @uditagarwal97
    uditagarwal97 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    88ae8af View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Wrap changes in PREVIEW_BREAKING_FLAG

    @uditagarwal97
    uditagarwal97 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2c33af1 View commit details
    Browse the repository at this point in the history

  2. Fix formating

    @uditagarwal97
    uditagarwal97 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    efef104 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Create a new header for vector

    @uditagarwal97
    uditagarwal97 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    49d83f3 View commit details
    Browse the repository at this point in the history

  2. Refactor sycl::vec into a header of its own.

    @uditagarwal97
    uditagarwal97 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b22b47b View commit details
    Browse the repository at this point in the history

  3. Fix formatting and LIT tests

    @uditagarwal97
    uditagarwal97 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b0dc2f9 View commit details
    Browse the repository at this point in the history

  4. Create a seperate header for ABI breaking changes.

    @uditagarwal97
    uditagarwal97 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    aa43da1 View commit details
    Browse the repository at this point in the history

  5. Create a new header for vector

    @uditagarwal97
    uditagarwal97 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    e45b3c6 View commit details
    Browse the repository at this point in the history

  6. Create a seperate header for ABI breaking changes.

    @uditagarwal97
    uditagarwal97 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d7adc6e View commit details
    Browse the repository at this point in the history

  7. Refactor sycl::vec into a header of its own.

    @uditagarwal97
    uditagarwal97 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    259240c View commit details
    Browse the repository at this point in the history

  8. Merge branch 'vec_header_preview_changes' into vector-refac

    @uditagarwal97
    uditagarwal97 authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f640f02 View commit details
    Browse the repository at this point in the history

  9. Fix no line at EOF

    @uditagarwal97
    uditagarwal97 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    34fdbc6 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Add device code tests for vector operations.

    @uditagarwal97
    uditagarwal97 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8c285a8 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Remove redundant code

    @uditagarwal97
    uditagarwal97 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    49fa63d View commit details
    Browse the repository at this point in the history

  2. Add line at EOF

    @uditagarwal97
    uditagarwal97 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4516e75 View commit details
    Browse the repository at this point in the history

  3. Simplify code

    @uditagarwal97
    uditagarwal97 committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e8adc8a View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Merge the test cases. Add detailed checks

    @uditagarwal97
    uditagarwal97 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    eb8b8b7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'vector_add_device_code_tests' into vector-refac

    @uditagarwal97
    uditagarwal97 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    3879fe9 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Don't use ext_vector for bool with ! operator

    @uditagarwal97
    uditagarwal97 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ec0717d View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge remote-tracking branch 'upstream/sycl' into vector-refac

    @uditagarwal97
    uditagarwal97 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    fb8fba3 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/sycl' into vector-refac

    @uditagarwal97
    uditagarwal97 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    75df511 View commit details
    Browse the repository at this point in the history

  3. Remove redundant changes

    @uditagarwal97
    uditagarwal97 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3b652fb View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Update vec device code test

    @uditagarwal97
    uditagarwal97 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    55329df View commit details
    Browse the repository at this point in the history

  2. Merge branch 'sycl' into vector-refac

    @uditagarwal97
    uditagarwal97 authored May 1, 2024
    Configuration menu
    Copy the full SHA
    3d9b9d0 View commit details
    Browse the repository at this point in the history

  3. Update test

    @uditagarwal97
    uditagarwal97 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    fc95f45 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'vector-refac' of https://github.com/uditagarwal97/llvm … 

    …into vector-refac
    @uditagarwal97
    uditagarwal97 committed May 1, 2024
    Configuration menu
    Copy the full SHA
    be95897 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Remove storage type alias

    @uditagarwal97
    uditagarwal97 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f71b232 View commit details
    Browse the repository at this point in the history

  2. clang format

    @uditagarwal97
    uditagarwal97 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    c7eba64 View commit details
    Browse the repository at this point in the history

  3. clang-format

    @uditagarwal97
    uditagarwal97 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    61dd7d4 View commit details
    Browse the repository at this point in the history

  4. Optimize operations on half

    @uditagarwal97
    uditagarwal97 committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5dd79c0 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Removed VecStorage type aliases

    @uditagarwal97
    uditagarwal97 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    d4da05d View commit details
    Browse the repository at this point in the history

  2. Remove some vec_helper stuff

    @uditagarwal97
    uditagarwal97 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8aa33e4 View commit details
    Browse the repository at this point in the history

  3. Replace HalfStorage with half as storage type for sycl::half vec

    @uditagarwal97
    uditagarwal97 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0b223b8 View commit details
    Browse the repository at this point in the history

  4. Fix

    @uditagarwal97
    uditagarwal97 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6b09e14 View commit details
    Browse the repository at this point in the history

  5. Fix comments. DCE

    @uditagarwal97
    uditagarwal97 committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4eb19da View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. Make std::byte as storage type for vec<byte,_>

    @uditagarwal97
    uditagarwal97 committed May 4, 2024
    Configuration menu
    Copy the full SHA
    2451cc2 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. More DCE. Refactor std::byte sycl::vec

    @uditagarwal97
    uditagarwal97 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    04d9121 View commit details
    Browse the repository at this point in the history

  2. Fix sycl::vec BFloat16

    @uditagarwal97
    uditagarwal97 committed May 7, 2024
    Configuration menu
    Copy the full SHA
    26987f4 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. For Num=1, store as array<_, 1>

    @uditagarwal97
    uditagarwal97 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1c85fc8 View commit details
    Browse the repository at this point in the history

  2. Limit math operations to their designated types, as per the SPEC.

    @uditagarwal97
    uditagarwal97 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    3812b8c View commit details
    Browse the repository at this point in the history

  3. Add guard before using std::byte

    @uditagarwal97
    uditagarwal97 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    62dd74d View commit details
    Browse the repository at this point in the history

  4. clang format

    @uditagarwal97
    uditagarwal97 committed May 8, 2024
    Configuration menu
    Copy the full SHA
    54e9c25 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Update dev code. Replace union UB with __builtin_bit_cast

    @uditagarwal97
    uditagarwal97 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    4ec3cc1 View commit details
    Browse the repository at this point in the history

  2. Remove unnessary use of vec_data casts.

    @uditagarwal97
    uditagarwal97 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    76a2ca3 View commit details
    Browse the repository at this point in the history

  3. Address reviews

    @uditagarwal97
    uditagarwal97 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    3073a13 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'sycl' into vector-refac

    @uditagarwal97
    uditagarwal97 authored May 9, 2024
    Configuration menu
    Copy the full SHA
    668334b View commit details
    Browse the repository at this point in the history

  5. Fix test failure for half swizzles.

    @uditagarwal97
    uditagarwal97 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    1ec252d View commit details
    Browse the repository at this point in the history

  6. Fix build on Windows

    @uditagarwal97
    uditagarwal97 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f1b7496 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'sycl' into vector-refac

    @uditagarwal97
    uditagarwal97 authored May 9, 2024
    Configuration menu
    Copy the full SHA
    4b63aff View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Address reviews

    @uditagarwal97
    uditagarwal97 committed May 13, 2024
    Configuration menu
    Copy the full SHA
    2e85695 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Address reviews

    @uditagarwal97
    uditagarwal97 committed May 14, 2024
    Configuration menu
    Copy the full SHA
    66c30bc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'sycl' into vector-refac

    @uditagarwal97
    uditagarwal97 authored May 14, 2024
    Configuration menu
    Copy the full SHA
    4dd04bd View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Address reviews. Fix formatting and tests

    @uditagarwal97
    uditagarwal97 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5579f7b View commit details
    Browse the repository at this point in the history

  2. Fix cformatting

    @uditagarwal97
    uditagarwal97 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3b6da03 View commit details
    Browse the repository at this point in the history

  3. Remove invert logic for NumElements=1 as we now use ext_vector_type f… 

    …or all sizes.
    @uditagarwal97
    uditagarwal97 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    48713c7 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Address reviews

    @uditagarwal97
    uditagarwal97 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    9376a62 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @uditagarwal97
    uditagarwal97 committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a953f6a View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Replace static_cast<vector_t> with sycl::bit_cast

    @uditagarwal97
    uditagarwal97 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    d41f747 View commit details
    Browse the repository at this point in the history

  2. Add asserts. Address reviews.

    @uditagarwal97
    uditagarwal97 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    561a225 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. All tests passing, including CTS. Address reviews

    @uditagarwal97
    uditagarwal97 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4a89d59 View commit details
    Browse the repository at this point in the history

  2. Merge byte_preview and byte

    @uditagarwal97
    uditagarwal97 committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f4b965c View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Fix vector/byte E2E test case. Restrict swizzles of std::byte to limi… 

    …ted operators.
    @uditagarwal97
    uditagarwal97 committed May 24, 2024
    Configuration menu
    Copy the full SHA
    cf9d905 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Store bool as it is, not as int8_t. All test passing.

    @uditagarwal97
    uditagarwal97 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1e61bd1 View commit details
    Browse the repository at this point in the history

  2. Refactor setValue and getValue

    @uditagarwal97
    uditagarwal97 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    79012b7 View commit details
    Browse the repository at this point in the history

  3. Address reviews.

    @uditagarwal97
    uditagarwal97 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1b260d0 View commit details
    Browse the repository at this point in the history

  4. Fix formatting

    @uditagarwal97
    uditagarwal97 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    935c139 View commit details
    Browse the repository at this point in the history

  5. clang-format; update check_device_code/vector

    @uditagarwal97
    uditagarwal97 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    7f3badd View commit details
    Browse the repository at this point in the history

  6. Remove cast

    @uditagarwal97
    uditagarwal97 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    273229a View commit details
    Browse the repository at this point in the history