Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Use std::array as storage for syc::vec on device #13270

Closed
wants to merge 90 commits into from
Closed

[SYCL] Use std::array as storage for syc::vec on device #13270

wants to merge 90 commits into from

Conversation

uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Apr 3, 2024 •
edited by aelovikov-intel
Loading

Changing the storage to std::array instead of Clang's extension fixes strict ansi-alising violation and simplifies device code.
This PR also cleans up sycl::vec code.

@uditagarwal97 uditagarwal97 self-assigned this Apr 3, 2024
@uditagarwal97
Copy link
Contributor Author

LIT tests failures:
Failed Tests (2):
SYCL :: basic_tests/types.cpp
SYCL :: basic_tests/vectors/constexpr-constructor.cpp

@uditagarwal97 uditagarwal97 marked this pull request as ready for review April 11, 2024 16:08
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner April 11, 2024 16:08
aelovikov-intel
aelovikov-intel reviewed Apr 11, 2024
View reviewed changes
sycl/include/sycl/detail/generic_type_traits.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/types.hpp Outdated Show resolved Hide resolved
@uditagarwal97
Copy link
Contributor Author

uditagarwal97 commented May 22, 2024 •
edited
Loading

TODO: Add value_type and element_type in sycl::vec #12954

aelovikov-intel
aelovikov-intel reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I forgot to submit my previous review comments. Doing it now, but keep it mind that might have become stale with the newest revision.

sycl/include/sycl/vector_preview.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/vector_preview.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/vector_preview.hpp Outdated Show resolved Hide resolved
aelovikov-intel
aelovikov-intel reviewed May 28, 2024
View reviewed changes
sycl/include/sycl/vector_preview.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/vector_preview.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/vector_preview.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/vector_preview.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/vector_preview.hpp Outdated Show resolved Hide resolved
This was referenced Jun 10, 2024
Merged
Merged
aelovikov-intel pushed a commit that referenced this pull request Jun 12, 2024
@uditagarwal97
[SYCL] Use std::array as storage for sycl::vec on device (#14130)
e7defab 
Replaces #13270

Changing the storage to std::array instead of Clang's extension fixes
strict ansi-aliasing violation and simplifies device code.
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
@uditagarwal97 @ianayl
[SYCL] Use std::array as storage for sycl::vec on device (intel#1…
a48a126 
…4130)

Replaces intel#13270

Changing the storage to std::array instead of Clang's extension fixes
strict ansi-aliasing violation and simplifies device code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel left review comments

@maarquitos14 maarquitos14 Awaiting requested review from maarquitos14 maarquitos14 is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees

@uditagarwal97 uditagarwal97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uditagarwal97 @aelovikov-intel