-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Switch post-commit to use old working image. #13769
Conversation
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@@ -32,7 +32,7 @@ jobs: | |||
build_artifact_suffix: sprod_shared | |||
build_configure_extra_args: --shared-libs --no-assertions --hip --cuda --native_cpu --cmake-opt="-DSYCL_ENABLE_STACK_PRINTING=ON" --cmake-opt="-DSYCL_LIB_WITH_DEBUG_SYMBOL=ON" | |||
# Docker image has last nightly pre-installed and added to the PATH | |||
build_image: "ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:build" | |||
build_image: "ghcr.io/intel/llvm/ubuntu2204_build:latest-cc1dd89176dd35522d57022a57204b41ae2611a9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be a sycl_ubuntu2204_nightly
image instead of a ubuntu2204_build
image? Maybe like build-cfd0d41a6a3b2e7a25fdea41202c7ad12091bde2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether it matters, but I can change it. I thought I'd just use the same image to be consistent with expected results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit builds with gcc, post-commit builds with clang, looking at the error message, I suspect it's using the nightly's DPC++ build to provide clang++, so I'm not sure it would work with the regular build image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@npmiller is correct and I should have noticed it when reviewing :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit builds with gcc, post-commit builds with clang, looking at the error message, I suspect it's using the nightly's DPC++ build to provide clang++, so I'm not sure it would work with the regular build image
I see that makes sense now. I've updated it to use the last tagged nightly build, from 14 days ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#13771 will fingers crossed solve the issues and allow use of "latest".
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
This swaps the post-commit from using the nightly image back to an old working image, the same one used in
#13618
#13606
This is a temporary solution to fix post-commit whilst I continue to try to find a long term solution to build rocm that doesn't break anything.