Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Switch post-commit to use old working image. #13769

Closed
wants to merge 2 commits into from
Closed

[CI] Switch post-commit to use old working image. #13769

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af89ea7
Switch post-commit to use old working image.
JackAKirk May 13, 2024
c3e211a
Use last tagged nightly image.
JackAKirk May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/sycl-post-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
build_artifact_suffix: sprod_shared
build_configure_extra_args: --shared-libs --no-assertions --hip --cuda --native_cpu --cmake-opt="-DSYCL_ENABLE_STACK_PRINTING=ON" --cmake-opt="-DSYCL_LIB_WITH_DEBUG_SYMBOL=ON"
# Docker image has last nightly pre-installed and added to the PATH
build_image: "ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:build"
build_image: "ghcr.io/intel/llvm/ubuntu2204_build:latest-cc1dd89176dd35522d57022a57204b41ae2611a9"
Copy link
Contributor

@npmiller npmiller May 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a sycl_ubuntu2204_nightly image instead of a ubuntu2204_build image? Maybe like build-cfd0d41a6a3b2e7a25fdea41202c7ad12091bde2

From https://ghcr.io/intel/llvm/sycl_ubuntu2204_nightly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether it matters, but I can change it. I thought I'd just use the same image to be consistent with expected results.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit builds with gcc, post-commit builds with clang, looking at the error message, I suspect it's using the nightly's DPC++ build to provide clang++, so I'm not sure it would work with the regular build image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@npmiller is correct and I should have noticed it when reviewing :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit builds with gcc, post-commit builds with clang, looking at the error message, I suspect it's using the nightly's DPC++ build to provide clang++, so I'm not sure it would work with the regular build image

I see that makes sense now. I've updated it to use the last tagged nightly build, from 14 days ago.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13771 will fingers crossed solve the issues and allow use of "latest".

cc: clang
cxx: clang++
merge_ref: ''
Expand Down
Loading