[SYCL][Bindless] Refactor existing bindless aspects for missing L0 bindless functionality #14323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndless functionality Add device aspects query if a device supports image arrays, unique addressing per dimension and support for sampling 1D usm images. Remove export semaphore, export image memory and fetch 3D usm image aspects as they are not supported on any backend. Update Level Zero and CUDA aspect results to reflect current support status with latest drivers.
|
Corresponding UR PR: oneapi-src/unified-runtime#1795 |
isaacault
approved these changes
Jul 9, 2024
|
Friendly ping @intel/dpcpp-tools-reviewers @intel/unified-runtime-reviewers @intel/llvm-reviewers-runtime @againull |
againull
approved these changes
Jul 9, 2024
|
Friendly ping @intel/dpcpp-tools-reviewers |
|
@intel/dpcpp-tools-reviewers Review please. |
|
@sarnex @intel/dpcpp-tools-reviewers Please review. Need approval as soon as you can. |
kbenzie
reviewed
Jul 23, 2024
There was a problem hiding this comment.
oneapi-src/unified-runtime#1795 has been merged, please update the UR repo/tag as suggested and pull in the latest changes from the sycl branch.
|
@intel/llvm-gatekeepers LGTM |
hdelan
pushed a commit
to hdelan/llvm
that referenced
this pull request
Jul 26, 2024
…ndless functionality (intel#14323) Add device aspects query if a device supports image arrays, unique addressing per dimension and support for sampling 1D usm images. Remove export semaphore, export image memory and fetch 3D usm image aspects as they are not supported on any backend. Update Level Zero and CUDA aspect results to reflect current support status with latest drivers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add device aspects query if a device supports image arrays, unique addressing per dimension and support for sampling 1D usm images.
Remove export semaphore, export image memory and fetch 3D usm image aspects as they are not supported on any backend.
Update Level Zero and CUDA aspect results to reflect current support status with latest drivers.