Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bindless][Exp] Update device_info enum elements and update Level Zero and CUDA backend device_info supported features #1795

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Bindless][Exp] Update device_info enum elements and update Level Zero and CUDA backend device_info supported features #1795

merged 1 commit into from
Jul 23, 2024

Conversation

DBDuncan
Copy link
Contributor

@DBDuncan DBDuncan commented Jun 27, 2024 •
edited
Loading

Add support to query if a device supports image arrays, unique addressing per dimension and support for sampling 1D/2D usm images.

Remove export semaphore, export image memory and fetch 3D usm image aspects as they are not supported on any backend.

Update Level Zero and CUDA backend device_info supported features.

@DBDuncan DBDuncan requested review from a team as code owners June 27, 2024 11:35
@github-actions github-actions bot added loader Loader related feature/bug images UR images specification Changes or additions to the specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues labels Jun 27, 2024
@DBDuncan DBDuncan changed the title [Bindless][Exp] Add missing device_info enum elements, remove unneeded ones and update Level Zero backend device_info supported features [Bindless][Exp] Update device_info enum elements and update Level Zero and CUDA backend device_info supported features Jun 27, 2024
@DBDuncan DBDuncan mentioned this pull request Jun 27, 2024
Merged
@DBDuncan
Copy link
Contributor Author

Corresponding UR PR: intel/llvm#14323

@DBDuncan
Copy link
Contributor Author

DBDuncan commented Jul 2, 2024

Friendly ping @oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-level-zero-write @steffenlarsen

@DBDuncan
Copy link
Contributor Author

DBDuncan commented Jul 3, 2024

Friendly ping @oneapi-src/unified-runtime-level-zero-write. Need approval.

@DBDuncan DBDuncan force-pushed the duncan/bindless-aspects branch 3 times, most recently from b967785 to 9c3f748 Compare July 9, 2024 13:18
@ProGTX
Copy link
Contributor

ProGTX commented Jul 11, 2024

Another friendly ping for @oneapi-src/unified-runtime-level-zero-write to review

@pbalcer pbalcer added ready to merge Added to PR's which are ready to merge and removed ready to merge Added to PR's which are ready to merge labels Jul 12, 2024
@pbalcer
Copy link
Contributor

pbalcer commented Jul 12, 2024 •
edited
Loading

Another friendly ping for @oneapi-src/unified-runtime-level-zero-write to review

Done.

I was too quick to add "ready to merge". Please make sure the CI passes. I restarted it just now, but if it fails, please investigate why.

@DBDuncan
Copy link
Contributor Author

Another friendly ping for @oneapi-src/unified-runtime-level-zero-write to review

Done.

I was too quick to add "ready to merge". Please make sure the CI passes. I restarted it just now, but if it fails, please investigate why.

Thanks! I have rebased this PR. Likely all the failures are due to the newish end to end tests that pull the head of the sycl DPC++ branch instead of the coresponding DPC++ PR linked that is causing issues. Will double check once CI finished again.

@DBDuncan
Copy link
Contributor Author

I have taken a look at the failing tests and a few of the end to end tests are failing because it pulls the head of the DPC++ sycl branch instead of the one linked to this PR and so compiling fails as it tried to use enum values that were removed.

@isaacault isaacault added the ready to merge Added to PR's which are ready to merge label Jul 18, 2024
@DBDuncan DBDuncan force-pushed the duncan/bindless-aspects branch 2 times, most recently from 89cbc7a to 26ed281 Compare July 22, 2024 15:19
@DBDuncan
[Bindless][Exp] Update device_info enum elements and update Level Zer…
40902ec 
…o and CUDA backend device_info supported features

Add support to query if a device supports image arrays, unique addressing per dimension and support for sampling 1D/2D usm images.

Remove export semaphore, export image memory and fetch 3D usm image aspects as they are not supported on any backend.

Update Level Zero and CUDA backend device_info supported features.
@kbenzie kbenzie merged commit f11caf9 into oneapi-src:main Jul 23, 2024
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@aarongreig aarongreig aarongreig approved these changes

@isaacault isaacault isaacault approved these changes

@pbalcer pbalcer pbalcer approved these changes

Assignees
No one assigned
Labels
cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification images UR images level-zero L0 adapter specific issues loader Loader related feature/bug ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DBDuncan @ProGTX @pbalcer @isaacault @aarongreig @steffenlarsen @kbenzie