[SYCL][Bindless][Doc][ABI-Break] Rename external semaphore destroy to release #14535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… release Rename function destroy_external_semaphore to release_external_semaphore. This name change is to clarify exactly what is happening to the external semaphore. That is, it is being released not destroyed.
JackAKirk
reviewed
Jul 11, 2024
| @@ -1904,16 +1904,16 @@ the `ext_oneapi_signal_external_semaphore` call complete. | |||
| are non-blocking, asynchronous operations. | |||
|
|
|||
| The user must ensure to destroy all external semaphore objects once they are no | |||
There was a problem hiding this comment.
Suggested change
| The user must ensure to destroy all external semaphore objects once they are no | |
| The user must ensure to release all external semaphore objects once they are no |
?
There was a problem hiding this comment.
I've updated the wording in the spec as it might cause confusion as to what exactly is being destroyed.
aelovikov-intel
approved these changes
Jul 11, 2024
PietroGhg
approved these changes
Jul 12, 2024
ProGTX
added
abi-break
przemektmalon
approved these changes
Jul 15, 2024
DBDuncan
approved these changes
Jul 15, 2024
kbenzie
approved these changes
Jul 18, 2024
|
@intel/llvm-gatekeepers can we merge this please? The failure in CI is unrelated to this PR. |
|
Merging, issue seems like an antivirus problem on the runner, not a source problem and we aren't seeing this anywhere else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename function destroy_external_semaphore to release_external_semaphore.
This name change is to clarify exactly what is happening to the external semaphore. That is, it is being released not destroyed.
Corresponding UR PR: oneapi-src/unified-runtime#1855