[Bindless][Exp] Rename external semaphore destroy func to release #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
przemektmalon
approved these changes
Jul 11, 2024
pbalcer
approved these changes
Jul 12, 2024
Seanst98
force-pushed
the
sean/rename-external-semaphore-release
branch
from
e7e465f
to
60eb35f
Compare
|
Friendly ping @oneapi-src/unified-runtime-native-cpu-write, @oneapi-src/unified-runtime-opencl-write, @oneapi-src/unified-runtime-cuda-write, @npmiller. Thanks! |
PietroGhg
approved these changes
Jul 15, 2024
|
Friendly ping @oneapi-src/unified-runtime-opencl-write, @oneapi-src/unified-runtime-cuda-write, and @npmiller for reviews. We'd like to get this in for the ABI-Break window. Thanks! |
aarongreig
approved these changes
Jul 16, 2024
Rename function urBindlessImagesDestroyExternalSemaphoreExp to urBindlessImagesReleaseExternalSemaphoreExp. This name change is to clarify exactly what is happening to the external semaphore. That is, it is being released not destroyed.
Seanst98
force-pushed
the
sean/rename-external-semaphore-release
branch
from
60eb35f
to
037d3b5
Compare
npmiller
approved these changes
Jul 17, 2024
kbenzie
added a commit
that referenced
this pull request
Jul 17, 2024
…l-semaphore-release"" This reverts commit b26e53c.
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 18, 2024
… release (#14535) Rename function destroy_external_semaphore to release_external_semaphore. This name change is to clarify exactly what is happening to the external semaphore. That is, it is being released not destroyed. Corresponding UR PR: oneapi-src/unified-runtime#1855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename function urBindlessImagesDestroyExternalSemaphoreExp to urBindlessImagesReleaseExternalSemaphoreExp.
This name change is to clarify exactly what is happening to the external semaphore. That is, it is being released not destroyed.
Corresponding DPC++ PR: intel/llvm#14535