[SYCL] Refactor FPGA Memory Attributes Validation for Clarity and and Efficiency #14566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LIntelRegister, SYCLIntelMemory) This patch uses MutualExclusions tablegen support to allow us to remove a custom diagnostic checking codes with FPGA attributes: [[intel:fpga_register]] and [[intel::fpga_memory]]. No test is added as we alreday have an existing LIT test (SemaSYCL/local.cpp) that shows the behavior.
…ency This commit refactors the CheckValidFPGAMemoryAttributesVar function in SemaDeclAttr.cpp to improve the clarity and efficiency of the validation logic for FPGA memory attributes on variables. The updated implementation streamlines the condition checks, making the code easier to read and understand. Key changes include: - Simplifying the conditional logic to reduce complexity. - Using direct return statements for immediate feedback on validation status. - Enhancing readability by clearly separating checks for different variable types and attributes. This refactor ensures that the function more clearly expresses its intent, making the codebase more accessible for future development and optimizations. No functional changes are intended with this refactor; it aims solely at improving code quality and readability. Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
changed the title
|
The failure is unrelated to my patch: Failed Tests (1): |
elizabethandrews
approved these changes
Jul 17, 2024
|
Thank you @elizabethandrews for reviews! |
|
@intel/llvm-gatekeepers, This PR is ready to merge. Thank you |
not related and already fixed in other commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the CheckValidFPGAMemoryAttributesVar function in SemaDeclAttr.cpp to improve the clarity and efficiency of the validation logic for 11 FPGA memory attributes on variables. The updated implementation streamlines the condition checks, making the code easier to read and understand.
Key changes include:
- Simplifying the conditional logic to reduce complexity.
- Using direct return statements for immediate feedback on validation status.
- Enhancing readability by clearly separating checks for different variable types and attributes.
This refactor ensures that the function more clearly expresses its intent, making the codebase more accessible for future development and optimizations.
No functional changes are intended with this refactor; it aims solely at improving code quality and readability.
Signed-off-by: Soumi Manna soumi.manna@intel.com