[SYCL][NFCI] Drop ESIMD emulator leftovers #15495
Open
+15
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intel#4020 introduced some kind of wrapper for SYCL kernels on host to be able to launch them on ESIMD emulator backend. Even though we had dropped that feature since then, we didn't remove corresponding `handler.hpp` modifications. This PR removes them. The main effect expected from this PR is compilation time improvement: those kernel wrappers are specialized by kernel name, meaning that there will be plenty of extra useless functions emitted during host compilation pass for every kernel in a program. This patch also uncovered a missing case in `HostKernel::InstantiateKernelOnHost` which we couldn't ever encounter because we transformed a host kernel to always accept `nd_item`, thus always skipping problematic `item` code path. This PR is not expected to introduce any functional changes, but since I'm not very familiar with the SYCL RT, I'm not entirely sure of that.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
There was a problem hiding this comment.
Changes LGTM overall. However, I'm not very familiar with how InstantiateKernelOnHost is used, so, I'd request an additional review from @aelovikov-intel
sycl/include/sycl/handler.hpp
Outdated
| KernelType *KernelPtr = | ||
| ResetHostKernel<KernelType, LambdaArgType, Dims>(KernelFunc); | ||
| MHostKernel.reset( | ||
| new detail::HostKernel<KernelType, LambdaArgType, Dims>(KernelFunc)); |
There was a problem hiding this comment.
should it be = std::make_unique?
There was a problem hiding this comment.
Originally I simply reverted this code to its older state, but applied make_unique in ed3589e
aelovikov-intel
approved these changes
Sep 24, 2024
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
commented
Sep 24, 2024
There was a problem hiding this comment.
@steffenlarsen should be able to share some insights about that method of HostKernel, because he was the one who [re-?]introduced it not that long ago
sycl/include/sycl/handler.hpp
Outdated
| KernelType *KernelPtr = | ||
| ResetHostKernel<KernelType, LambdaArgType, Dims>(KernelFunc); | ||
| MHostKernel.reset( | ||
| new detail::HostKernel<KernelType, LambdaArgType, Dims>(KernelFunc)); |
There was a problem hiding this comment.
Originally I simply reverted this code to its older state, but applied make_unique in ed3589e
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4020 introduced some kind of wrapper for SYCL kernels on host to be able to launch them on ESIMD emulator backend. Even though we had dropped that feature since then, we didn't remove corresponding
handler.hppmodifications. This PR removes them.The main effect expected from this PR is compilation time improvement: those kernel wrappers are specialized by kernel name, meaning that there will be plenty of extra useless functions emitted during host compilation pass for every kernel in a program.
This patch also uncovered a missing case in
HostKernel::InstantiateKernelOnHostwhich we couldn't ever encounter because we transformed a host kernel to always acceptnd_item, thus always skipping problematicitemcode path.This PR is not expected to introduce any functional changes, but since I'm not very familiar with the SYCL RT, I'm not entirely sure of that.