Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][NFCI] Drop ESIMD emulator leftovers #15495

Commits on Sep 24, 2024

  1. [SYCL][NFCI] Drop ESIMD emulator leftovers

    intel#4020 introduced some kind of wrapper for SYCL kernels on host
    to be able to launch them on ESIMD emulator backend. Even though we had
    dropped that feature since then, we didn't remove corresponding
    `handler.hpp` modifications. This PR removes them.
    
    The main effect expected from this PR is compilation time improvement:
    those kernel wrappers are specialized by kernel name, meaning that there
    will be plenty of extra useless functions emitted during host compilation
    pass for every kernel in a program.
    
    This patch also uncovered a missing case in
    `HostKernel::InstantiateKernelOnHost` which we couldn't ever encounter
    because we transformed a host kernel to always accept `nd_item`, thus
    always skipping problematic `item` code path.
    
    This PR is not expected to introduce any functional changes, but since
    I'm not very familiar with the SYCL RT, I'm not entirely sure of that.
    AlexeySachkov committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    301258f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf21174 View commit details
    Browse the repository at this point in the history
  3. Apply review comments

    AlexeySachkov committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ed3589e View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    913db74 View commit details
    Browse the repository at this point in the history