feat(routing/http/server): add routing timeout #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #720 +/- ##
==========================================
+ Coverage 60.34% 60.35% +0.01%
==========================================
Files 243 243
Lines 31039 31056 +17
==========================================
+ Hits 18730 18745 +15
- Misses 10644 10645 +1
- Partials 1665 1666 +1
... and 5 files with indirect coverage changes 🚨 Try these New Features:
|
lidel
changed the title
lidel
approved these changes
Nov 19, 2024
lidel
added a commit
to ipfs/someguy
that referenced
this pull request
Nov 19, 2024
2color
added a commit
to ipfs/someguy
that referenced
this pull request
Nov 19, 2024
…request timeouts (#87) * fix: larger duration buckets for better visibility * feat: log accept header * fix: move instrumentation to boxo * feat: add tracing with auth token * feat: add 30 second request timeout * chore: remove replace directive * chore: add missing funcSampler * chore: remove request timeout this isn't working too well. We need to look more deeply into this * chore: update changelog * chore: go mod tidy * chore: go-libp2p-kad-dht v0.28.1 * chore: latest boxo#720 * chore: mod tidy * chore: boxo main with ipfs/boxo#720 and ipfs/boxo#718 * Apply suggestions from code review Co-authored-by: Marcin Rataj <lidel@lidel.org> * fix: typo --------- Co-authored-by: Daniel N <2color@users.noreply.github.com> Co-authored-by: Marcin Rataj <lidel@lidel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
See ipfs/someguy#88.
TL;DR: Without any routing timeout, routing requests will run indefinitely if the record limit isn't reached.