feat: add tracing, request timeouts and move instrumentation to boxo #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2color
changed the title
this isn't working too well. We need to look more deeply into this
This was referenced Nov 18, 2024
lidel
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Merged boxo PRs and switched this one to a commit from boxo main branch with both.
I think we should ship this do delegated-routing.dev, try to visualize metrics in grafana, nd see if bucket sizes make sense (duration should be ok, but sizes may be too big, we won't have 1GB response from routing system, IPNS record size is capped at 10KiB (https://specs.ipfs.tech/ipns/ipns-record/#record-size-limit)
@2color Feel free to merge this PR and then open one that releases this as v0.6.0
Co-authored-by: Marcin Rataj <lidel@lidel.org>
|
@lidel See ipfs/boxo#724 for updated size buckets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR
TraceparentheaderWhy
TL;DR: expose metrics per handler/route and use more
See ipfs/boxo#718.
Depends on