[skip changelog] staticcheck fixes / remove ununsed variables #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #730 +/- ##
==========================================
- Coverage 60.36% 60.35% -0.02%
==========================================
Files 244 244
Lines 31034 31015 -19
==========================================
- Hits 18734 18719 -15
- Misses 10630 10631 +1
+ Partials 1670 1665 -5 |
hsanjuan
commented
Nov 27, 2024
Comment on lines
-9
to
-10
| // these requests take at _least_ two minutes at the moment. | ||
| ProvideTimeout = time.Minute * 3 |
There was a problem hiding this comment.
The comment was introduced at 310fcba. Probably quite outdated and the reprovider settings take care now.
gammazero
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some very minor changes.