Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] staticcheck fixes / remove ununsed variables #730

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[skip changelog] staticcheck fixes / remove ununsed variables #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bitswap/internal/defaults/defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import (
)

const (
// these requests take at _least_ two minutes at the moment.
ProvideTimeout = time.Minute * 3
Comment on lines -9 to -10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment was introduced at 310fcba. Probably quite outdated and the reprovider settings take care now.

// ProvSearchDelay specifies how long to wait before we start
// broadcasting outstanding wants for the first time.
ProvSearchDelay = time.Second

// Number of concurrent workers in decision engine that process requests to the blockstore
Expand Down
2 changes: 1 addition & 1 deletion chunker/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func TestParseRabin(t *testing.T) {

_, err := FromString(r, "rabin-18-25-32")
if err != nil {
t.Errorf(err.Error())
t.Error(err.Error())
}

_, err = FromString(r, "rabin-15-23-31")
Expand Down