Update behavior of FromLegacy to make more flexible with materials #6672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
Current behavior of
FromLegacy
on a legacyTriangleMesh
with more than one material is to warn the user that Tensor-based meshes don't support multiple materials and not convert any materials. Annoyingly, sometimes our importers (mostly ASSIMP) import or create dummy materials so converting those to Tensor-basedTriangleMesh
result in meshes with no materials. With this PR those cases will convert to a Tensor-basedTriangleMesh
with the first material converted as well. In most cases this should produce a mesh with a usable material. In any case, a message is output to the user warning that only the first material was converted.Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description