Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in NearestNeighborSearch.h #6705

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Fix typos in NearestNeighborSearch.h #6705

merged 3 commits into from
Apr 1, 2024

Conversation

mone27
Copy link
Contributor

@mone27 mone27 commented Mar 19, 2024

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Fix typos in NearestNeighborSearch.h docstrings

Copy link

update-docs bot commented Mar 19, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@mone27 mone27 changed the title Fix typo in NearestNeighborSearch.h Fix typos in NearestNeighborSearch.h Mar 19, 2024
Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mone27 thanks for fixing the typos. You can find other identical typos with this:

$ git grep indicecs # from repo main folder
cpp/open3d/core/nns/NNSIndex.h:    /// - indicecs: Tensor of shape {total_num_neighbors,}, dtype Int32.
cpp/open3d/core/nns/NNSIndex.h:    /// - indicecs: Tensor of shape {total_num_neighbors,}, dtype Int32.
cpp/open3d/core/nns/NanoFlannIndex.h:    /// - indicecs: Tensor of shape {total_num_neighbors,}, dtype Int32.
cpp/open3d/core/nns/NanoFlannIndex.h:    /// - indicecs: Tensor of shape {total_num_neighbors,}, dtype Int32.
cpp/open3d/core/nns/NearestNeighborSearch.h:    /// - indicecs: Tensor of shape {total_number_of_neighbors,}, with dtype
cpp/open3d/core/nns/NearestNeighborSearch.h:    /// - indicecs: Tensor of shape {total_number_of_neighbors,}, with dtype

Would you be able to fix those as well? (Also for distainces...)

@mone27
Copy link
Contributor Author

mone27 commented Mar 24, 2024

Yes sure! Didn't realized that there are similar issues in also other files

@mone27
Copy link
Contributor Author

mone27 commented Apr 1, 2024

I should have fixed now all indices and distances typos in core/nns

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mone27 !

@ssheorey ssheorey merged commit 84b8e07 into isl-org:main Apr 1, 2024
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants