Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify data_ and data_interface_ in KDTreeFlann. #6734

Merged
merged 2 commits into from
Apr 17, 2024

Commits on Mar 29, 2024

  1. Simplify data_ and data_interface_ in KDTreeFlann.

    KDTreeFlann::SetRawData had some confusion around data, data_, and
    data_interface_. As a result, the data from the parameter was copied to
    the member std::vector, but the interface (which takes an Eigen::Map)
    used the data passed as an argument to the method.
    As a result, the searches risked to be run on a dangling pointer,
    instead of the intended internal storage.
    
    However, rather than adjusting the pointer for Eigen::Map, I preferred
    simplifying the code, and copy the argument to an Eigen::MatrixXd.
    PieroV committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    3ed4e34 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Configuration menu
    Copy the full SHA
    ef814ea View commit details
    Browse the repository at this point in the history