Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jpg
files withpng
extension and vice versa are read correctly.libjpeg
errors and report as normal Open3D exceptions. Change Open3D warnings to errors (exceptions) on jpeg I/O error.Output if a corrupt file is given to jpeglib:
Earlier, this used to crash the program (python or user C++ app, or Open3D viewer app) since libjpeg would immediately
exit()
with this error message.Breaking change: Image read errors now
Clear()
the image to ensure an older image cannot be used in error. This is in addition to a WARNING message and returningfalse
. We do not throw exceptions for Image IO, to be consistent with OpenCV.References:
Type
Motivation and Context
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description