Successfully built with llvm-19, imgui-1.90.6 and remove bug from std::move. #6788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
|
Hi @jiapei100 thanks for submitting this PR! Please describe the bug that you fixed, with a way to reproduce it in the current version. [Especially about |
ssheorey
requested changes
Jun 15, 2024
There was a problem hiding this comment.
Hi @jiapei100 Thanks for the updates. Can you also:
- update
3rdparty/imgui/imgui.cmaketo latest (1.90.6) - Test visualization examples (especially all_widgets.py) on your computer and let us know the OS and hardware that you tested on.
pip install clang-format~=10.0and runmake apply-styleto fix the style.
3rdparty/find_dependencies.cmake
Outdated
| /usr/lib/llvm-10/lib | ||
| /usr/lib/llvm-9/lib | ||
| /usr/lib/llvm-8/lib | ||
| /usr/lib/llvm-7/lib | ||
| ) |
There was a problem hiding this comment.
Hi @jiapei100 with this change, it will not build with older llvm / libc++ versions. Why did you remove support for older LLVM versions?
ssheorey
added
the
status / needs info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description