Fix segfault (lambda reference capture) of VisualizerWithCustomAnimation::Play #6804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
Fixing segmentation fault when running an animation (clicking CTRL+P) with
draw_geometries_with_custom_animation
.Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
The segmentation fault in VisualizerWithCustomAnimation.cpp is caused by line 124:
++progress_bar;
, withprogress_bar
being autility::ProgressBar
instance captured by reference by a lambda expression. It seems like a dangling reference. Convertingprogress_bar
to a shared pointer fixes the segmentation fault.Testing
Before the change, this MRE will raise a segmentation fault after clicking CTRL+N and CTRL+P; after the change, it will run correctly: