Update Intel libraries (MKL, TBB, IPP). Remove parallelSTL / oneDPL. #6809

ssheorey · 2024-06-02T08:15:58Z

Add VERSION (API version - major.minor.patch) and SOVERSION (ABI version major.minor) to libOpen3D
Preparing for OpenMP -> TBB conversion. TBB 2021.12.
Preparing for Intel GPU offload with new MKL (2024.1 for Win, Linux and 2023.2.2 for macOS).
Additional computer vision / image processing functions (e.g. optical flow) from new IPP (2021.11 for Win/Linux and 2021.9.1 for macOS)). No GPU support yet, but get automatic TBB based multi-threading inside image processing operations.
Switch to C++17.
TBB is now linked dynamically. TBB static linking is not supported and may cause over-subscription / crashes, especially in Python. TBB DSOs are now distributed with Open3D.

Type

Bug fix (non-breaking change which fixes an issue): Fixes Cannot compile on Ubuntu 23.10 #6544 (partially)
New feature (non-breaking change which adds functionality). Resolves #
Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Checklist:

I have run python util/check_style.py --apply to apply Open3D code style
to my code.
This PR changes Open3D behavior or adds new functionality.
- Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
  updated accordingly.
- I have added or updated C++ and / or Python unit tests OR included test
  results (e.g. screenshots or numbers) here.
I will follow up and update the code if CI fails.
For fork PRs, I have selected Allow edits from maintainers.

TBB linked dynamically - link errors

update-docs · 2024-06-02T08:16:02Z

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

IPP version check for directory layout TBB linking is still WIP Attempt with FetchContent.

Open3D viewer, libopen3d, pybind, tf_ops and torch_ops work

…lder.

…oneapi-update

…into ss/oneapi-update

…MSVC.

Windows linking fix style fix

Link to MKL before TBB to fix link errors.

Add TCM_ENABLE=1 to python

… requirements.

…dd to build and python wheel.

ssheorey · 2024-08-19T23:56:22Z

Ready to review....
macOS failure is due to download error. Earlier runs passed.

…fetchcontent to avoid Windows build errors

benjaminum

Just some minor questions from my side.

Is there anything that needs special attention?

cmake/Open3DSetGlobalProperties.cmake

python/open3d/__init__.py

3rdparty/find_dependencies.cmake

benjaminum

lgtm

ssheorey added 5 commits May 31, 2024 15:11

[WIP] Update TBB, MKL, DPL to latest

e3ef4e9

TBB linked dynamically - link errors

tbb undefined symbols fix

ffa1a82

update rpath, add tbb dso to wheel

fb12fc5

Link tbb with full path.

7b27edd

Add mkl download URLs and hashes.

146e222

ssheorey changed the title ~~Update MKL, TBB and parallel STL / DPL libraries~~ Update Intel libraries (MKL, TBB, parallel STL / DPL, IPP) Jun 2, 2024

ssheorey and others added 4 commits June 2, 2024 23:05

Update from IPP-ICV (from OpenCV) to 2021.11 IPP

c28a890

Fix ipp path

de04b88

IPP include dirs, test RPATH fix

419a241

Replace OneDPL with TBB in ParallelScan.h

e52a208

IPP version check for directory layout TBB linking is still WIP Attempt with FetchContent.

ssheorey changed the title ~~Update Intel libraries (MKL, TBB, parallel STL / DPL, IPP)~~ Update Intel libraries (MK,, TBB, IPP). Remove parallelSTL / oneDPL. Jun 16, 2024

ssheorey changed the title ~~Update Intel libraries (MK,, TBB, IPP). Remove parallelSTL / oneDPL.~~ Update Intel libraries (MKL, TBB, IPP). Remove parallelSTL / oneDPL. Jun 16, 2024

ssheorey and others added 11 commits July 26, 2024 18:54

fetchcontent

8e20d19

Open3D viewer, libopen3d, pybind, tf_ops and torch_ops work

Merge branch 'main' into ss/oneapi-update

6725b37

Add libtbb dependency to open3d viewer app deb package.

7f6b4a9

Windows: ensure pybind and tests have tbb12.dll present in the exe fo…

a09fd60

…lder.

Merge branch 'ss/oneapi-update' of github.com:isl-org/Open3D into ss/…

a856937

…oneapi-update

add tbb.lib to release

cd2977d

Merge branch 'ss/oneapi-update' of https://github.com/isl-org/Open3D …

3090869

…into ss/oneapi-update

style

c93c6cf

Allow pybind to load tbb12.dll and tbb12_debug.dll

39fb3d3

Add back C++17 warning suppression for stdgpu->thrust for CUDA 11 on …

cbf5e5c

…MSVC.

Merge branch 'main' of github.com:isl-org/Open3D into ss/oneapi-update

74c4bb6

ssheorey force-pushed the ss/oneapi-update branch from 9c4f67a to 488497e Compare August 10, 2024 06:03

ssheorey marked this pull request as ready for review August 10, 2024 06:03

ssheorey requested a review from benjaminum August 10, 2024 06:03

ssheorey and others added 3 commits August 9, 2024 23:05

Linux -start-group fix for MKL

488497e

Windows linking fix style fix

Delete 3rdparty/mkl/tbb.externalcontent.cmake

ab4987c

Add Open3D DSO by soname to Python package if BUILD_SHARED.

5f606b8

Link to MKL before TBB to fix link errors.

ssheorey added 5 commits August 12, 2024 13:40

bug fixes

41dfe66

bug fixes 2

7eeb6fd

try fix arm64 TLS error

e4338d2

Add TCM_ENABLE=1 to python

Update glibc version (2.31), Ubuntu version (20.04), C++ version (17)…

26d3de3

… requirements.

Filament also needs libunwind with newer llvm / libc++ / libc++abi. A…

e2111db

…dd to build and python wheel.

ssheorey force-pushed the ss/oneapi-update branch from 73b6b18 to e2111db Compare August 18, 2024 07:29

ssheorey added 4 commits August 18, 2024 23:31

libunwind find_library fix

ae2b592

cmake warnings fix

90743e2

fix apt install for libunwind

937a625

Revert libc++ and libc++abi to version 10 to avoid libunwind dependence

5553cb7

revert fetchcontent_makeavailable -> fetchcontent_populate for qhull …

3eb5962

…fetchcontent to avoid Windows build errors

benjaminum requested changes Aug 20, 2024

View reviewed changes

cmake/Open3DSetGlobalProperties.cmake Show resolved Hide resolved

python/open3d/__init__.py Show resolved Hide resolved

3rdparty/find_dependencies.cmake Show resolved Hide resolved

Add docstrings for options in open3d_find_package_3rdparty_library

e4402f2

benjaminum approved these changes Aug 20, 2024

View reviewed changes

ssheorey merged commit c219d82 into main Aug 20, 2024
39 of 45 checks passed

ssheorey deleted the ss/oneapi-update branch August 20, 2024 19:45

ssheorey mentioned this pull request Aug 21, 2024

Support python 312 #6717

Merged

9 tasks

Sheradil mentioned this pull request Sep 9, 2024

Open3Ds C++ does not compile on Ubuntu 24.04 #6956

Open

3 tasks

SomeoneSerge mentioned this pull request Oct 31, 2024

WIP: python311Packages.nerfstudio: init at 1.1.2 NixOS/nixpkgs#320599

Draft

13 tasks

Tobias-Fischer mentioned this pull request Nov 10, 2024

Enable aarch64 conda-forge/open3d-feedstock#15

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Intel libraries (MKL, TBB, IPP). Remove parallelSTL / oneDPL. #6809

Update Intel libraries (MKL, TBB, IPP). Remove parallelSTL / oneDPL. #6809

ssheorey commented Jun 2, 2024 •

edited

Loading

update-docs bot commented Jun 2, 2024

ssheorey commented Aug 19, 2024

benjaminum left a comment

benjaminum left a comment

Update Intel libraries (MKL, TBB, IPP). Remove parallelSTL / oneDPL. #6809

Update Intel libraries (MKL, TBB, IPP). Remove parallelSTL / oneDPL. #6809

Conversation

ssheorey commented Jun 2, 2024 • edited Loading

Type

Checklist:

update-docs bot commented Jun 2, 2024

ssheorey commented Aug 19, 2024

benjaminum left a comment

Choose a reason for hiding this comment

benjaminum left a comment

Choose a reason for hiding this comment

ssheorey commented Jun 2, 2024 •

edited

Loading