Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Intel libraries (MKL, TBB, IPP). Remove parallelSTL / oneDPL. #6809

Merged
merged 34 commits into from
Aug 20, 2024

Conversation

ssheorey
Copy link
Member

@ssheorey ssheorey commented Jun 2, 2024

  1. Add VERSION (API version - major.minor.patch) and SOVERSION (ABI version major.minor) to libOpen3D
  2. Preparing for OpenMP -> TBB conversion. TBB 2021.12.
  3. Preparing for Intel GPU offload with new MKL (2024.1 for Win, Linux and 2023.2.2 for macOS).
  4. Additional computer vision / image processing functions (e.g. optical flow) from new IPP (2021.11 for Win/Linux and 2021.9.1 for macOS)). No GPU support yet, but get automatic TBB based multi-threading inside image processing operations.
  5. Switch to C++17.
  6. TBB is now linked dynamically. TBB static linking is not supported and may cause over-subscription / crashes, especially in Python. TBB DSOs are now distributed with Open3D.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes Cannot compile on Ubuntu 23.10 #6544 (partially)
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Copy link

update-docs bot commented Jun 2, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey changed the title Update MKL, TBB and parallel STL / DPL libraries Update Intel libraries (MKL, TBB, parallel STL / DPL, IPP) Jun 2, 2024
@ssheorey ssheorey changed the title Update Intel libraries (MKL, TBB, parallel STL / DPL, IPP) Update Intel libraries (MK,, TBB, IPP). Remove parallelSTL / oneDPL. Jun 16, 2024
@ssheorey ssheorey changed the title Update Intel libraries (MK,, TBB, IPP). Remove parallelSTL / oneDPL. Update Intel libraries (MKL, TBB, IPP). Remove parallelSTL / oneDPL. Jun 16, 2024
@ssheorey ssheorey marked this pull request as ready for review August 10, 2024 06:03
@ssheorey
Copy link
Member Author

Ready to review....
macOS failure is due to download error. Earlier runs passed.

Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor questions from my side.

Is there anything that needs special attention?

cmake/Open3DSetGlobalProperties.cmake Show resolved Hide resolved
python/open3d/__init__.py Show resolved Hide resolved
3rdparty/find_dependencies.cmake Show resolved Hide resolved
Copy link
Contributor

@benjaminum benjaminum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ssheorey ssheorey merged commit c219d82 into main Aug 20, 2024
39 of 45 checks passed
@ssheorey ssheorey deleted the ss/oneapi-update branch August 20, 2024 19:45
@ssheorey ssheorey mentioned this pull request Aug 21, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compile on Ubuntu 23.10
2 participants