Support lowercase types (i, u, f) when reading PCD files #6930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
Other libraries, like PCL, support both lowercase types (
i
,u
,f
) and their uppercase "official" counterpart (I
,U
,F
) when loading PCD files. Currently, Open3D raises an error for lowercase types when usingopen3d.t.io
, or loads a 0.0 value when usingopen3d.io
, without any warning/error.Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Add support for lowercase types when reading PCD files by using
std::toupper(type, std::locale())
.Testing
Trying to load pc_example.zip (notice
TYPE f f f
instead ofTYPE F F F
):with script:
Before
After