Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maint/pmd update rules #248

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Maint/pmd update rules #248

merged 3 commits into from
Nov 5, 2024

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Nov 4, 2024 •
edited
Loading

Description

Update refarch-pmd-ruleset:

  • TooManyStaticImports conflicts with forbidden * imports

@simonhir simonhir requested a review from a team as a code owner November 4, 2024 07:30
@simonhir simonhir self-assigned this Nov 4, 2024
@github-actions github-actions bot added Type: Maintenance The issue contains maintenance work. Component: Tools Issues regarding the dev tools labels Nov 4, 2024
@simonhir simonhir mentioned this pull request Nov 4, 2024
Merged
@DanielOber
Copy link
Contributor

DanielOber commented Nov 4, 2024 •
edited
Loading

  • TooManyStaticImports I agree that this rule can be removed, as it doesn't seem particularly beneficial.
  • CouplingBetweenObjects This rule doesn't seem overly problematic. Why do you want to disable it entirely?
  • UseObjectForClearerAPI This rule is actually pretty solid and even gets a shout-out in "Clean Code." Sure, there can be exceptions, but I don’t see why we should turn it off completely.

@simonhir
Copy link
Member Author

simonhir commented Nov 5, 2024 •
edited
Loading

@DanielOber don't really know anymore why i excluded them instead of suppressing them ...
Refactored it, now only the static imports are excluded.
Thanks for the review

devtobi
devtobi approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@devtobi devtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhir simonhir merged commit f619cc7 into main Nov 5, 2024
11 checks passed
@simonhir simonhir deleted the maint/pmd-update-rules branch November 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devtobi devtobi devtobi approved these changes

Assignees

@simonhir simonhir

Labels
Component: Tools Issues regarding the dev tools Type: Maintenance The issue contains maintenance work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonhir @DanielOber @devtobi