Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gto): update push option descriptions #4879

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

shcheklein
Copy link
Member

Per iterative/gto#417

Updates the --push CLI option in gto register and similar commands to reflect the current state of the commands.

@shcheklein shcheklein self-assigned this Sep 23, 2023
@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) C: gto labels Sep 23, 2023
shcheklein added a commit to iterative/gto that referenced this pull request Sep 23, 2023
Fixes #405 

We've changed the semantic of the operation during the recent migration
to `scmrepo`. The key thing is the `has_remote(reg.scm)` calls and
implementation. I think the original intention was to push automatically
when we run GTO operations on a remote repo (means we are cloning it
into a temp dir, do some op, and push the result back).

## TODO

- [x] Tests
- [x] Review CLI option description
- [x] Review docs

## Docs

Relevant docs update is here
iterative/dvc.org#4879
@shcheklein shcheklein temporarily deployed to dvc-org-gto-update-push-v2l1rn September 23, 2023 22:51 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2023

Link Check Report

There were no links to check!

Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed the notification for this. Left one minor comment.

@shcheklein shcheklein force-pushed the gto-update-push-description branch from 8da17d9 to 70009cd Compare September 26, 2023 22:05
@shcheklein shcheklein temporarily deployed to dvc-org-gto-update-push-v2l1rn September 26, 2023 22:05 Inactive
@shcheklein shcheklein force-pushed the gto-update-push-description branch from 70009cd to ae1e42b Compare September 26, 2023 22:06
@shcheklein shcheklein temporarily deployed to dvc-org-gto-update-push-v2l1rn September 26, 2023 22:07 Inactive
@shcheklein shcheklein enabled auto-merge (squash) September 26, 2023 22:42
@shcheklein shcheklein disabled auto-merge September 26, 2023 22:42
@shcheklein shcheklein merged commit b546b61 into main Sep 26, 2023
4 checks passed
@shcheklein shcheklein deleted the gto-update-push-description branch September 26, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: gto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants