fix(registry): push to remote automatically only on cloned repos #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
|
LGTM, I'm ok with merging this and doing tests in a follow up if a customer needs the fix |
|
For the record - added tests, updated docs before merging this. It was approved by Peter here #417 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405
We've changed the semantic of the operation during the recent migration to
scmrepo. The key thing is thehas_remote(reg.scm)calls and implementation. I think the original intention was to push automatically when we run GTO operations on a remote repo (means we are cloning it into a temp dir, do some op, and push the result back).TODO
Docs
Relevant docs update is here iterative/dvc.org#4879