Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edge cases empty code block #4061

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: edge cases empty code block #4061

merged 1 commit into from
Nov 21, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Nov 20, 2024

Describe Your Changes

hide copy element when code block empty

Screenshot 2024-11-21 at 01 04 21

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Nov 20, 2024
@urmauur urmauur added this to the v0.5.9 milestone Nov 20, 2024
@urmauur urmauur self-assigned this Nov 20, 2024
Copy link
Contributor

Barecheck - Code coverage report

Total: 69.26%

Your code coverage diff: -0.02% ▾

Uncovered files and lines
FileLines
web/screens/Thread/ThreadCenterPanel/SimpleTextMessage/index.tsx51-55, 57-58, 61, 64, 72-75, 77, 81, 88-90, 96, 99-102, 107-108, 111, 161, 163-164, 169-170, 229, 234-238, 240-242, 244-245, 247-249, 252-254, 256-257, 332, 355

@urmauur urmauur merged commit 0039c52 into dev Nov 21, 2024
11 checks passed
@urmauur urmauur deleted the fix/empty-code-block branch November 21, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: [UI Bug] Code block - Copy icon alignment issue
2 participants