Misc improvements 11 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes unused `#addPreDependencyOf:on:` and `#addPostDependencyOf:on:` from `TRRegisterDependencies`
This commit moves `TRCompilationTestShell` and subclasses to category "Tinyrossa-Tests-Shells", removing "-SmalltalkX". These classes are no longer Smalltalk/X specific.
This commit removes `compilation` instvar introduced in commit 84b2519 "Implement `TRCompilationTestShell >> #call` and `#call:`". In a hindsight, this does not seem proper. We need to be able to test compilation of multiple functions calling each other, so the there'll be "multiple compilations". Removing `compilation` from shell prompted refactoring of `call`, `call:` and `call:_:` utility methods - they need to take `compilation` as a first parameter. While at it, split code injection and call to actual function into two method to facilitate tests with multiple functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.