-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for EXT_texture_webp #253
Conversation
Oops, it's EXT_texture_webp, not KHR_texture_webp. |
This needs to be structured like KHR_texture_basisu; the current implementation for example doesn’t support specifying both png and webp images. Also missing cgltf_write support. |
support for EXT_texture_webp.
How does it look now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, one more thing - this needs a call to CGLTF_PTRFIXUP in cgltf_fixup_pointers for the newly added pointer field.
I added a call to CGLTF_PTRFIXUP in cgltf_fixup_pointers. Hopefully should be fine now. |
And one more thing 😅 I think this is missing writing the appropriate extension name in |
Lots of things I missed when grepping. Completed now perhaps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've confirmed the parsing works in gltfpack (can't confirm cgltf_write changes since gltfpack doesn't use this but should be good on inspection). cc @jkuhlmann
This is currently pending a merge to upstream: jkuhlmann/cgltf#253
Specification:
https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0/Vendor/EXT_texture_webp