Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Update to latest Polars #36

Closed
wants to merge 5 commits into from

Conversation

stefanDeveloper
Copy link

@stefanDeveloper stefanDeveloper commented Sep 16, 2024

Currently, the latest polars version is 1.7.1. Our project https://github.com/stefanDeveloper/heiDGAF relies on this library, so it would be great to update it.

@jordandelbar
Copy link
Owner

Sure! I am on vacation for the next two weeks without access to my computer and I'll merge your PR once I am back. Can you aim your PR at the dev branch instead of main? I'll create a release by merging it into main afterwards. Thanks!

@jordandelbar jordandelbar changed the base branch from main to dev September 16, 2024 16:37
@jordandelbar
Copy link
Owner

I realized I can change the target branch from GitHub mobile. However, the poetry.lock file is not up to date with the pyproject.toml which is causing the tests to fail. You'll need to run a poetry lock and push the updated poetry.lock

@stefanDeveloper
Copy link
Author

I realized I can change the target branch from GitHub mobile. However, the poetry.lock file is not up to date with the pyproject.toml which is causing the tests to fail. You'll need to run a poetry lock and push the updated poetry.lock

Thanks for your quick reply! I updated the poetry.lock.

@jordandelbar jordandelbar changed the title Update to latest Polars chore!: Update to latest Polars Sep 17, 2024
@jordandelbar
Copy link
Owner

Thanks! I tried running the GitHub actions, but it seems I forgot to merge main back into dev after the last release. I'll need to check this on a proper terminal, not just on my phone 😅. I've added a reminder to fix this and merge your PR by the 30th of September. I also need to add a contributing guide, as the commits must follow the conventional commits specification to correctly generate the changelog.md

@stefanDeveloper
Copy link
Author

Thanks! I tried running the GitHub actions, but it seems I forgot to merge main back into dev after the last release. I'll need to check this on a proper terminal, not just on my phone 😅. I've added a reminder to fix this and merge your PR by the 30th of September. I also need to add a contributing guide, as the commits must follow the conventional commits specification to correctly generate the changelog.md

Thanks for the quick response.
That would be great, in the future we might have more contributions. A contributing guide is a helpful note!

@jordandelbar
Copy link
Owner

Changes were merged in #38
Thanks again for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants