基于Kotlin重构Android插件代码并支持多Flutter engine和更精准的result回调管理 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techwn
commented
Jun 28, 2021
Comment on lines
+16
to
+30
| Pair(JPushInterface.EXTRA_EXTRA, notificationExtras), | ||
| Pair(JPushInterface.EXTRA_ALERT_TYPE, notificationAlertType), | ||
| Pair(JPushInterface.EXTRA_NOTIFICATION_ID, notificationId), | ||
| Pair(JPushInterface.EXTRA_MSG_ID, msgId), | ||
| Pair(JPushInterface.EXTRA_ALERT, notificationContent), | ||
| Pair(JPushInterface.EXTRA_NOTIFICATION_TITLE, notificationTitle), | ||
| Pair(JPushInterface.EXTRA_NOTI_TYPE, notificationType), | ||
| Pair(JPushInterface.EXTRA_BIG_TEXT, notificationBigText), | ||
| Pair(JPushInterface.EXTRA_INBOX, notificationInbox), | ||
| Pair(JPushInterface.EXTRA_BIG_PIC_PATH, notificationBigPicPath), | ||
| Pair(JPushInterface.EXTRA_NOTI_PRIORITY, notificationPriority), | ||
| Pair(JPushInterface.EXTRA_NOTI_CATEGORY, notificationCategory), | ||
| Pair(JPushInterface.EXTRA_NOTIFICATION_SMALL_ICON, notificationSmallIcon), | ||
| Pair(JPushInterface.EXTRA_NOTIFICATION_LARGET_ICON, notificationLargeIcon), | ||
| Pair(JPushInterface.EXTRA_TYPE_PLATFORM, platform), |
There was a problem hiding this comment.
这块是基于41项JPushInterface. EXTRA_XXX和NotificationMessage相关的属性名字整理出来的15条，其中删除了现有官方要求忽略的几条，如有错漏请补充（我们内部其实只会用到第一条）。
techwn
commented
Jun 28, 2021
Comment on lines
+5
to
7
| <receiver android:name="com.jiguang.jpush.JPushEventReceiver" | ||
| android:enabled="true" | ||
| android:exported="false"> |
There was a problem hiding this comment.
这里的修改是基于官方文档，添加enabled和exported属性以消除警告
techwn
changed the title
|
放弃吧...你看他们鸟你吗...这就是你国内上游厂商🤮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
现有JPushPlugin的职责太多
所以拆分JPushPlugin的缓存和回调分发功能到单例类：JPushCallbackDispatcher。
JPushPlugin专注于onMethodCall的dart端代码调用处理。
另外删除静态内部类JPushPlugin$JPushReceiver，相关功能合并到JPushEventReceiver
架构变化如下：
