Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.5.x: Unpin pyzmq #7305

Merged
merged 1 commit into from
Apr 17, 2024
Merged

6.5.x: Unpin pyzmq #7305

merged 1 commit into from
Apr 17, 2024

Conversation

minrk
Copy link
Member

@minrk minrk commented Mar 28, 2024

temporary pin applied to both jupyter-client 8 and pyzmq 25 in #6749 appears resolved with jupyter-client 7.4.9 (or jupyter-core 5.3.2?), at least in terms of pyzmq.

I tried to follow all of the examples in #6721 with pyzmq 25.1.2 and saw no errors, but can't be completely sure.

Pinning down pyzmq prevents installation of notebook (and thereby jupyterlab 3 and others) on Python 3.12, since pyzmq 25.1 is the first version to support 3.12, so there's a real cost to keeping a pin here if the problem is fixed elsewhere.

temporary pin applied to both jupyter-client 8 and pyzmq 25 _appears_ resolved with jupyter-client 7.49 (or jupyter-core 5.3.2?)

pinning pyzmq<25 prevents installation on Python 3.12, which requires pyzmq >=25.1
@jtpio
Copy link
Member

jtpio commented Apr 12, 2024

cc @RRosio @ericsnekbytes this looks like something we might want to get in a 6.5.x release. Not sure about the CI failures though

@jtpio jtpio added this to the 6.5 milestone Apr 12, 2024
@RRosio
Copy link
Collaborator

RRosio commented Apr 15, 2024

Thank you for the ping @jtpio! It looks like the CI failures are not related to this change in particular. I can merge this and try addressing at least some of those in a follow-up PR.

The test_check seems to be a rule for branch protection but since its status is still Expected, I am wondering if there is another way I can still try merging?

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think we can ignore the failing checks for this particular PR to move forward with this fix.

@jtpio jtpio merged commit 382a5db into jupyter:6.5.x Apr 17, 2024
20 of 34 checks passed
@jtpio
Copy link
Member

jtpio commented Apr 17, 2024

@RRosio if you would like to try making a release with the releaser, hopefully it will still work for that branch

@RRosio
Copy link
Collaborator

RRosio commented Apr 17, 2024

Thank you @jtpio, it looks like I cannot use Jupyter Releaser
Screenshot 2024-04-17 at 1 07 17 PM.

Would it be best to continue with the manual release instructions?: https://github.com/jupyter/notebook/blob/6.5.x/RELEASE.md

Although, I was thinking I will not be able to push the commits and tags due to the expected status check.

@jtpio
Copy link
Member

jtpio commented Apr 18, 2024

@RRosio maybe it's possible to use the workflow from the main branch, and specify 6.5.x for the target branch?

image

Normally the release bot should be able to push to the branch and bypass the branch protection rule.

@RRosio
Copy link
Collaborator

RRosio commented Apr 18, 2024

Thank you @jtpio, I was able to try running the workflow, however it looks like I do not have the permissions so the run failed: https://github.com/jupyter/notebook/actions/runs/8745004773/job/23999102632

@jtpio
Copy link
Member

jtpio commented Apr 24, 2024

@RRosio Thanks for trying. I just added you to the repo with hopefully the correct permissions to run the workflow.

@RRosio
Copy link
Collaborator

RRosio commented May 1, 2024

The final release can be found here: https://github.com/jupyter/notebook/releases/tag/v6.5.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants