Scan /oem the last one #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there is bundled configs, plus userdata, the userdata should be read at the end to be able to override any existing configs bundled with the system, as userdata is more dynamic.
nianyush
approved these changes
Sep 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
=======================================
Coverage 49.71% 49.71%
=======================================
Files 48 48
Lines 4584 4584
=======================================
Hits 2279 2279
Misses 2028 2028
Partials 277 277 ☔ View full report in Codecov by Sentry. |
jimmykarily
approved these changes
Sep 25, 2024
|
Requires some kind of docs to document this, so users know they can override a bundled config in an iso with userdata |
mauromorales
approved these changes
Sep 26, 2024
|
closed in favor of #562 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there is bundled configs, plus userdata, the userdata should be read at the end to be able to override any existing configs bundled with the system, as userdata is more dynamic.