Draft: Logs SDK, OTLP exporter #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogRecord implements the read-write log record as described in the Logs SDK spec.
…pentelemetry-ruby into otlp-log-record-exporter
This reduces the number of retries that run during tests to speed up the tests
kaylareopelle
commented
Nov 20, 2024
| @@ -28,7 +28,11 @@ module OpenTelemetry | |||
|
|
|||
| # @return [Object, Logger] configured Logger or a default STDOUT Logger. | |||
| def logger | |||
| @logger ||= Logger.new($stdout, level: ENV['OTEL_LOG_LEVEL'] || Logger::INFO) | |||
| @logger ||= create_logger | |||
There was a problem hiding this comment.
These changes are directly related to the Logs instrumentation. They need a PR when the logs instrumentation is ready for review.
Without this fix, the version constants for the OTLP exporter for traces collides with the OTLP exporter for logs.
…telemetry-ruby into log-record-processor3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an implementation of the OpenTelemetry Logs SDK and an OTLP exporter for Ruby. This implementation awaits review and approval from OTel Ruby maintainers/approvers.
The commits in this PR will be cherry-picked to become smaller PRs to keep this work easy to review.
Current PR under consideration: open-telemetry#1611
OpenTelemetry Logs SDK Specification
OpenTelemetry Spec Compliance Matrix - Logs
OpenTelemetry Ruby Logs Project Board