forked from open-telemetry/opentelemetry-ruby
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Logs SDK, OTLP exporter #6
Draft
kaylareopelle
wants to merge
136
commits into
main
Choose a base branch
from
log-record-processor3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 128 commits
Commits
Show all changes
136 commits
Select commit
Hold shift + click to select a range
f8dddfe
Implement LoggerProvider#logger
kaylareopelle 0dc0f7c
Associate a Resource with LoggerProvider
kaylareopelle b917fa9
resource, processors, mutex
kaylareopelle b618b84
Write test for add_log_record_processor
kaylareopelle d9609be
Implement LoggerProvider#shutdown
kaylareopelle e7aa448
LoggerProvider#shutdown with arg on processor
kaylareopelle 8869933
Temp class comment on LogRecordProcessor
kaylareopelle dcb307a
LogRecordProcessor#force_flush
kaylareopelle 96f89bd
Cleanup
kaylareopelle 44665d3
Bump versions
kaylareopelle 201e517
Address feedback from fallwith
kaylareopelle 6feaf08
Add more tests
kaylareopelle 6a9abd3
Update tests and error handling
kaylareopelle 2c8c3d3
Docs updates
kaylareopelle 6791bc9
Add links
kaylareopelle 7652a59
feat: Create SDK LogRecord
kaylareopelle 78e6008
Update documentation
kaylareopelle 98b5b06
draft log record processors
kaylareopelle 71b6414
More WIP log record processors
kaylareopelle c943ca9
Initial log_record_processor
kaylareopelle db1a5a5
Initial simple log record processor
kaylareopelle 81873ac
Initial Batch log record processor
kaylareopelle 44e6d14
Add Logger#emit
kaylareopelle e53996a
Add LogRecordData
kaylareopelle d93f7b1
Add LogRecordExporter
kaylareopelle 7845691
Remove processor from logs.rb
kaylareopelle 55cb5d2
Move log record processor out of export
kaylareopelle b8a8304
Fix module name Log => Logs
kaylareopelle e0bdfe0
Trace => Logs test definition for log record processor
kaylareopelle 5093d82
Trace => Logs exporter test
kaylareopelle 43afe4d
Add log record processor tests
kaylareopelle e8cedbc
Move log_record_processor test out of export
kaylareopelle 4e5d312
Sketch out tests for simple processor
kaylareopelle 98ac3c6
Add test for #force_flush return value on exporter
kaylareopelle fdba25b
Remove hex methods from log_record_data, not used
kaylareopelle 1704f42
Add Logger#emit tests
kaylareopelle 5f7a051
Add tests for simple log record processor
kaylareopelle 133c97a
Define LogRecord#to_log_record_data
kaylareopelle 535af7b
Exclude test files from Simplecov
kaylareopelle a071638
WIP test
kaylareopelle b1e3756
initial in memory log record exporter
kaylareopelle baab58b
Add ExportError
kaylareopelle 354cb85
Update BatchLogRecordProcessor
kaylareopelle 7488f7a
Finish batch_log_record_processor tests
kaylareopelle 0b638af
Add ConsoleLogRecordExporter
kaylareopelle 8a403a8
Finish InMemoryLogRecordExporter
kaylareopelle b5ace43
Update ConsoleLogRecordExporter tests
kaylareopelle c5b2194
Add force_flush test for InMemoryLogRecordExporter
kaylareopelle 00ab8df
Initial LogRecordLimits work
kaylareopelle 703f57a
Fix LogRecordLimits
kaylareopelle e1deddc
Remote limits todo
kaylareopelle 03eb454
Remove log record processor todo
kaylareopelle 2e57f60
Remove simple span processor todo
kaylareopelle 679c222
Implement log record attribute limits
kaylareopelle b56739b
Fix assert_nil in log record test
kaylareopelle 2b000ee
Remove sampling from simple log record processor
kaylareopelle bb0d736
LogRecordExporter remove sampled text
kaylareopelle cf30286
InMemoryLogRecordExporter remove sampled text
kaylareopelle 702502b
BatchLogRecordProcessor remove sampled
kaylareopelle 6c3c252
Make SpanContext optional in LogRecord#to_log_record_data
kaylareopelle dd9b877
Add @skip_instrumenting to OpenTelemetry.logger
kaylareopelle 46011ab
Initial commit otlp-logs
kaylareopelle 4d8e5f3
Add logger_provider methods to logs_api
kaylareopelle b964d45
Create proxy_logger and proxy_logger_provider
kaylareopelle de28615
Add instrument_registry to Logs::Logger
kaylareopelle 7f877d3
Create configuration patch to export logs w/sdk
kaylareopelle 15e1fd8
Add unix_nano methods for LogRecordData timestamps
kaylareopelle 41fe05b
Add instrumentation_regirstry to LoggerProvider
kaylareopelle 63936a4
Logger - span_context by default, remove arg
kaylareopelle 74d7878
Update logger provider tests to account for error message constant an…
kaylareopelle 8e93285
LogRecordProcessor on_emit => emit
kaylareopelle 59d06a9
Fix logger#emit test
kaylareopelle c0d5507
Add severity_number and dropped attributes logic
kaylareopelle 86fc525
Update copied exporter test for logs exporter
kaylareopelle 04b8144
Add create_log_record_data to test helpers
kaylareopelle 5c85a3d
Create add_log_record_processor method in Configurator
kaylareopelle 9776315
Add stopped and registry tests to logger provider
kaylareopelle 60e7378
Update timestamp default to include :nanosecond in Logger
kaylareopelle 6c93b03
Document log record limits arg on LoggerProvider#initialize
kaylareopelle 7a3c42c
LogRecord updates for attribute counting, nanosecond time
kaylareopelle 23bfc49
Logger update docs to use :nanosecond
kaylareopelle c74c92b
Create add_log_record_processor method in configuration patch
kaylareopelle 5cf254d
Update timestamp methods to use correct format, add total_recorded_attrs
kaylareopelle 3c03cc9
Merge branch 'main' into log-record-processor3
kaylareopelle adda555
Log result code
kaylareopelle f524ee6
Add some logging
kaylareopelle c0595b7
Remove API Severity Number
kaylareopelle 35d861f
Add changes from LoggerProvider PR, merge main
kaylareopelle 6c1b008
Merge branch 'main' into log-record-processor3
kaylareopelle 55799eb
Merge branch 'main' into log-record-processor3
kaylareopelle 65e13be
Update version of OTLP logs
kaylareopelle 619dd16
Remove error logs with HTTP response
kaylareopelle 9bf5910
feat: Update use of Context/SpanContext
kaylareopelle ccecc77
Skip failing logger provider registry test
kaylareopelle 3795ae9
chore: Update logger test
kaylareopelle 0171761
chore: Update condition to match upstream
kaylareopelle bd16be2
Merge pull request #8 from kaylareopelle/span_context_to_context
kaylareopelle 5c01a4c
Merge branch 'main' into log-record-processor-with-emit-updates
kaylareopelle 98580c5
Update log_record_limits
kaylareopelle c79f528
Merge pull request #9 from kaylareopelle/log-record-processor-with-em…
kaylareopelle 1d7f17e
chore: Refactor log attribute truncation
kaylareopelle 97880fe
chore: Test refactors
kaylareopelle 1f7c92c
chore: Rubocop
kaylareopelle bcfa2af
Merge branch 'main' into log-record-processor3
kaylareopelle ea0a49c
Merge branch 'main' into log-record-processor3
kaylareopelle d44183d
feat: Create OTLP Logs Exporter
kaylareopelle ee8cda1
test: Skip intermittently failing test
kaylareopelle a64bdaa
ci: Add OTLP logs exporter to CI
kaylareopelle 112cd21
test: Skip intermittent failure
kaylareopelle 41d32fd
test: Client cert fixes
kaylareopelle 7cba668
chore: Readme updates
kaylareopelle e5c03c3
Merge branch 'main' into log-record-processor3
kaylareopelle bcd4041
Merge branch 'main' into otlp-log-record-exporter
kaylareopelle 1e6545d
Merge branch 'otlp-log-record-exporter' of github.com:kaylareopelle/o…
kaylareopelle 18ec40f
ci: Exclude otlp-logs from JRuby CI, alphabetize
kaylareopelle a1bcf49
docs: Update README to use logs URL
kaylareopelle 385ed1d
chore: Add tiny version to Appraisal
kaylareopelle f8ead31
chore: Update google-protobuf version, Appraisals
kaylareopelle 4dc0f9f
chore: Rubocop single quotes over double quotes
kaylareopelle e7af001
test: Add minitest-stub-const
kaylareopelle abfcd54
feat: Add log output for send_bytes failure cases
kaylareopelle 6fbbce6
Merge branch 'main' into otlp-log-record-exporter
kaylareopelle 60c0021
chore: Remove outdated :exception kwarg
kaylareopelle 77192b5
test: Loosen message match for SystemCallError
kaylareopelle 09ad663
Merge branch 'main' into otlp-log-record-exporter
kaylareopelle 91a2edd
Merge branch 'main' into log-record-processor3
kaylareopelle e8f058c
Merge branch 'otlp-log-record-exporter' into log-record-processor3
kaylareopelle 1f12daa
chore: Remove outdated file
kaylareopelle 31ff063
chore: misc backports to sync with main
kaylareopelle 9fe2faa
fix: Add Logs namespace to exporter
kaylareopelle 0b105b8
style: Rubocop spacing
kaylareopelle e9e872b
Merge branch 'main' into log-record-processor3
kaylareopelle e87ed23
chore: Clean up code to match upstream
kaylareopelle 873f64a
Merge branch 'log-record-processor3' of github.com:kaylareopelle/open…
kaylareopelle 5d243bb
chore: Remove unncessary mutex/instrument registry
kaylareopelle 43ca962
Add post_install message warning branch deletion
kaylareopelle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
inherit_from: | ||
- ../../contrib/rubocop.yml | ||
|
||
AllCops: | ||
Exclude: | ||
- "lib/opentelemetry/proto/**/*" | ||
- "vendor/**/*" | ||
|
||
Naming/FileName: | ||
Exclude: | ||
- lib/opentelemetry-exporter-otlp-logs.rb | ||
Style/StringLiterals: | ||
Exclude: | ||
- gemfiles/**/* | ||
Style/FrozenStringLiteralComment: | ||
Exclude: | ||
- gemfiles/**/* | ||
Metrics/BlockLength: | ||
Enabled: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--no-private | ||
--title=OpenTelemetry OTLP Logs Exporter | ||
--markup=markdown | ||
--main=README.md | ||
./lib/opentelemetry/exporter/otlp-logs/**/*.rb | ||
./lib/opentelemetry/exporter/otlp.rb | ||
- | ||
README.md | ||
CHANGELOG.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# frozen_string_literal: true | ||
|
||
# Copyright The OpenTelemetry Authors | ||
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
appraise 'google-protobuf-3.18.0' do | ||
gem 'google-protobuf', '~> 3.18.0' | ||
end | ||
|
||
appraise 'google-protobuf-3.25.0' do | ||
gem 'google-protobuf', '~> 3.25.0' | ||
end | ||
|
||
appraise 'google-protobuf-4.29.0' do | ||
gem 'google-protobuf', '~> 4.29.0' | ||
end | ||
|
||
appraise 'google-protobuf-latest' do | ||
gem 'google-protobuf' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# Release History: opentelemetry-exporter-otlp-logs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# frozen_string_literal: true | ||
|
||
# Copyright The OpenTelemetry Authors | ||
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
source 'https://rubygems.org' | ||
|
||
gemspec | ||
|
||
group :test, :development do | ||
gem 'opentelemetry-api', path: '../../api' | ||
gem 'opentelemetry-common', path: '../../common' | ||
gem 'opentelemetry-logs-api', path: '../../logs_api' | ||
gem 'opentelemetry-logs-sdk', path: '../../logs_sdk' | ||
gem 'opentelemetry-registry', path: '../../registry' | ||
gem 'opentelemetry-sdk', path: '../../sdk' | ||
gem 'opentelemetry-semantic_conventions', path: '../../semantic_conventions' | ||
gem 'opentelemetry-test-helpers', path: '../../test_helpers' | ||
end | ||
|
||
group :test do | ||
gem 'minitest-stub-const' | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,201 @@ | ||
Apache License | ||
Version 2.0, January 2004 | ||
http://www.apache.org/licenses/ | ||
|
||
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION | ||
|
||
1. Definitions. | ||
|
||
"License" shall mean the terms and conditions for use, reproduction, | ||
and distribution as defined by Sections 1 through 9 of this document. | ||
|
||
"Licensor" shall mean the copyright owner or entity authorized by | ||
the copyright owner that is granting the License. | ||
|
||
"Legal Entity" shall mean the union of the acting entity and all | ||
other entities that control, are controlled by, or are under common | ||
control with that entity. For the purposes of this definition, | ||
"control" means (i) the power, direct or indirect, to cause the | ||
direction or management of such entity, whether by contract or | ||
otherwise, or (ii) ownership of fifty percent (50%) or more of the | ||
outstanding shares, or (iii) beneficial ownership of such entity. | ||
|
||
"You" (or "Your") shall mean an individual or Legal Entity | ||
exercising permissions granted by this License. | ||
|
||
"Source" form shall mean the preferred form for making modifications, | ||
including but not limited to software source code, documentation | ||
source, and configuration files. | ||
|
||
"Object" form shall mean any form resulting from mechanical | ||
transformation or translation of a Source form, including but | ||
not limited to compiled object code, generated documentation, | ||
and conversions to other media types. | ||
|
||
"Work" shall mean the work of authorship, whether in Source or | ||
Object form, made available under the License, as indicated by a | ||
copyright notice that is included in or attached to the work | ||
(an example is provided in the Appendix below). | ||
|
||
"Derivative Works" shall mean any work, whether in Source or Object | ||
form, that is based on (or derived from) the Work and for which the | ||
editorial revisions, annotations, elaborations, or other modifications | ||
represent, as a whole, an original work of authorship. For the purposes | ||
of this License, Derivative Works shall not include works that remain | ||
separable from, or merely link (or bind by name) to the interfaces of, | ||
the Work and Derivative Works thereof. | ||
|
||
"Contribution" shall mean any work of authorship, including | ||
the original version of the Work and any modifications or additions | ||
to that Work or Derivative Works thereof, that is intentionally | ||
submitted to Licensor for inclusion in the Work by the copyright owner | ||
or by an individual or Legal Entity authorized to submit on behalf of | ||
the copyright owner. For the purposes of this definition, "submitted" | ||
means any form of electronic, verbal, or written communication sent | ||
to the Licensor or its representatives, including but not limited to | ||
communication on electronic mailing lists, source code control systems, | ||
and issue tracking systems that are managed by, or on behalf of, the | ||
Licensor for the purpose of discussing and improving the Work, but | ||
excluding communication that is conspicuously marked or otherwise | ||
designated in writing by the copyright owner as "Not a Contribution." | ||
|
||
"Contributor" shall mean Licensor and any individual or Legal Entity | ||
on behalf of whom a Contribution has been received by Licensor and | ||
subsequently incorporated within the Work. | ||
|
||
2. Grant of Copyright License. Subject to the terms and conditions of | ||
this License, each Contributor hereby grants to You a perpetual, | ||
worldwide, non-exclusive, no-charge, royalty-free, irrevocable | ||
copyright license to reproduce, prepare Derivative Works of, | ||
publicly display, publicly perform, sublicense, and distribute the | ||
Work and such Derivative Works in Source or Object form. | ||
|
||
3. Grant of Patent License. Subject to the terms and conditions of | ||
this License, each Contributor hereby grants to You a perpetual, | ||
worldwide, non-exclusive, no-charge, royalty-free, irrevocable | ||
(except as stated in this section) patent license to make, have made, | ||
use, offer to sell, sell, import, and otherwise transfer the Work, | ||
where such license applies only to those patent claims licensable | ||
by such Contributor that are necessarily infringed by their | ||
Contribution(s) alone or by combination of their Contribution(s) | ||
with the Work to which such Contribution(s) was submitted. If You | ||
institute patent litigation against any entity (including a | ||
cross-claim or counterclaim in a lawsuit) alleging that the Work | ||
or a Contribution incorporated within the Work constitutes direct | ||
or contributory patent infringement, then any patent licenses | ||
granted to You under this License for that Work shall terminate | ||
as of the date such litigation is filed. | ||
|
||
4. Redistribution. You may reproduce and distribute copies of the | ||
Work or Derivative Works thereof in any medium, with or without | ||
modifications, and in Source or Object form, provided that You | ||
meet the following conditions: | ||
|
||
(a) You must give any other recipients of the Work or | ||
Derivative Works a copy of this License; and | ||
|
||
(b) You must cause any modified files to carry prominent notices | ||
stating that You changed the files; and | ||
|
||
(c) You must retain, in the Source form of any Derivative Works | ||
that You distribute, all copyright, patent, trademark, and | ||
attribution notices from the Source form of the Work, | ||
excluding those notices that do not pertain to any part of | ||
the Derivative Works; and | ||
|
||
(d) If the Work includes a "NOTICE" text file as part of its | ||
distribution, then any Derivative Works that You distribute must | ||
include a readable copy of the attribution notices contained | ||
within such NOTICE file, excluding those notices that do not | ||
pertain to any part of the Derivative Works, in at least one | ||
of the following places: within a NOTICE text file distributed | ||
as part of the Derivative Works; within the Source form or | ||
documentation, if provided along with the Derivative Works; or, | ||
within a display generated by the Derivative Works, if and | ||
wherever such third-party notices normally appear. The contents | ||
of the NOTICE file are for informational purposes only and | ||
do not modify the License. You may add Your own attribution | ||
notices within Derivative Works that You distribute, alongside | ||
or as an addendum to the NOTICE text from the Work, provided | ||
that such additional attribution notices cannot be construed | ||
as modifying the License. | ||
|
||
You may add Your own copyright statement to Your modifications and | ||
may provide additional or different license terms and conditions | ||
for use, reproduction, or distribution of Your modifications, or | ||
for any such Derivative Works as a whole, provided Your use, | ||
reproduction, and distribution of the Work otherwise complies with | ||
the conditions stated in this License. | ||
|
||
5. Submission of Contributions. Unless You explicitly state otherwise, | ||
any Contribution intentionally submitted for inclusion in the Work | ||
by You to the Licensor shall be under the terms and conditions of | ||
this License, without any additional terms or conditions. | ||
Notwithstanding the above, nothing herein shall supersede or modify | ||
the terms of any separate license agreement you may have executed | ||
with Licensor regarding such Contributions. | ||
|
||
6. Trademarks. This License does not grant permission to use the trade | ||
names, trademarks, service marks, or product names of the Licensor, | ||
except as required for reasonable and customary use in describing the | ||
origin of the Work and reproducing the content of the NOTICE file. | ||
|
||
7. Disclaimer of Warranty. Unless required by applicable law or | ||
agreed to in writing, Licensor provides the Work (and each | ||
Contributor provides its Contributions) on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
implied, including, without limitation, any warranties or conditions | ||
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A | ||
PARTICULAR PURPOSE. You are solely responsible for determining the | ||
appropriateness of using or redistributing the Work and assume any | ||
risks associated with Your exercise of permissions under this License. | ||
|
||
8. Limitation of Liability. In no event and under no legal theory, | ||
whether in tort (including negligence), contract, or otherwise, | ||
unless required by applicable law (such as deliberate and grossly | ||
negligent acts) or agreed to in writing, shall any Contributor be | ||
liable to You for damages, including any direct, indirect, special, | ||
incidental, or consequential damages of any character arising as a | ||
result of this License or out of the use or inability to use the | ||
Work (including but not limited to damages for loss of goodwill, | ||
work stoppage, computer failure or malfunction, or any and all | ||
other commercial damages or losses), even if such Contributor | ||
has been advised of the possibility of such damages. | ||
|
||
9. Accepting Warranty or Additional Liability. While redistributing | ||
the Work or Derivative Works thereof, You may choose to offer, | ||
and charge a fee for, acceptance of support, warranty, indemnity, | ||
or other liability obligations and/or rights consistent with this | ||
License. However, in accepting such obligations, You may act only | ||
on Your own behalf and on Your sole responsibility, not on behalf | ||
of any other Contributor, and only if You agree to indemnify, | ||
defend, and hold each Contributor harmless for any liability | ||
incurred by, or claims asserted against, such Contributor by reason | ||
of your accepting any such warranty or additional liability. | ||
|
||
END OF TERMS AND CONDITIONS | ||
|
||
APPENDIX: How to apply the Apache License to your work. | ||
|
||
To apply the Apache License to your work, attach the following | ||
boilerplate notice, with the fields enclosed by brackets "[]" | ||
replaced with your own identifying information. (Don't include | ||
the brackets!) The text should be enclosed in the appropriate | ||
comment syntax for the file format. We also recommend that a | ||
file or class name and description of purpose be included on the | ||
same "printed page" as the copyright notice for easier | ||
identification within third-party archives. | ||
|
||
Copyright The OpenTelemetry Authors | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are directly related to the Logs instrumentation. They need a PR when the logs instrumentation is ready for review.