Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the app full height in popout window #12

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

mariobuikhuizen
Copy link

Use the new class that is also available in a Solara popout window. Keep the styling of #popout-widget-container for backward compatibility with ipypopout<1.3.0.

Use the new class that is also available in a Solara popout window.
Keep the styling of #popout-widget-container for backward
compatibility with ipypopout<1.3.0.
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (standalone-solara@fda0b98). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             standalone-solara      #12   +/-   ##
====================================================
  Coverage                     ?   88.81%           
====================================================
  Files                        ?      112           
  Lines                        ?    17248           
  Branches                     ?        0           
====================================================
  Hits                         ?    15319           
  Misses                       ?     1929           
  Partials                     ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick, thanks! 🎉

@kecnry kecnry merged commit 25e2325 into kecnry:standalone-solara Jul 23, 2024
15 of 16 checks passed
kecnry pushed a commit that referenced this pull request Jul 30, 2024
Use the new class that is also available in a Solara popout window.
Keep the styling of #popout-widget-container for backward
compatibility with ipypopout<1.3.0.
kecnry pushed a commit that referenced this pull request Aug 15, 2024
Use the new class that is also available in a Solara popout window.
Keep the styling of #popout-widget-container for backward
compatibility with ipypopout<1.3.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants