Update system tests #647
Merged
Update system tests #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we have a system test failure: https://github.com/keep-network/tbtc-v2/actions/runs/5484145856 |
I ran this workflow before bumping the |
Request the redemption via the `depositorBridgeHandle.requestRedemption` directly instead of `requestRedemption` function. After refactoring in `#632`, the `requestRedemption` requests redemption via tBTC token contract. In the current deposit scenario, we do not pass the vault address so the `depositor` does not actually have any tBTC tokens so we can't request redemption via `requestRedemption` fn with changes from `#632`. We are going to add a new scenario where we pass the TBTC vault address to the `revealDeposit` function to test the new mechanism of requesting the redemption via tBTC token contract in follow-up work.
r-czajkowski
force-pushed
the
update-system-test
branch
from
ee3cab1
to
b56d4db
Compare
lukasz-zimnoch
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
LGTM! Will merge once https://github.com/keep-network/tbtc-v2/actions/runs/5529864532 turns green!
dimpar
added a commit
that referenced
this pull request
Aug 23, 2023
This PR adds additional system tests scenario in which deposit is revealed with a vault. This PR is a follow-up to #647. In the already existing scenario, the depositor revealed their deposit without specifying the vault. As a result the depositor had their blance increased in the Bank. In the new scenario the depositor reveals their deposit and provides the vault address. As a result TBTC tokens are minted for the depositor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request the redemption via the
depositorBridgeHandle.requestRedemptiondirectly instead of
requestRedemptionfunction. After refactoring in#632, the
requestRedemptionrequests redemption via tBTC tokencontract. In the current deposit scenario, we do not pass the vault
address so the
depositordoes not actually have any tBTC tokens so wecan't request redemption via
requestRedemptionfn with changes from#632. We are going to add a new scenario where we pass the TBTC vault
address to the
revealDepositfunction to test the new mechanism ofrequesting the redemption via tBTC token contract in follow-up work.