feat: Optimize bech32 Encoding Performance #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maciejka
requested changes
May 28, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized the Bech32 encoding implementation for better performance and efficiency:
-Constant ALPHABET: Defined ALPHABET as a global constant for Bech32 characters.
-Memory Preallocation: Preallocated memory for the encoded result in the encode function.
-Use of while Loops: Used while loops for controlled iteration in compliance with Cairo's constraints.
-Optimized byte-to-5-bit Conversion: Improved convert_bytes_to_5bit_chunks function with more efficient bitwise -operations.
-Optimized Checksum Calculation: Enhanced the checksum function for better array handling and efficiency.
These changes address the performance improvements requested in issue #74.
Before and After:
-Function convert_bytes_to_5bit_chunks After:
Before:
Function encode After:
Before:
Any suggestions are welcome, and I'm happy to make any changes you need. @maciejka @mubarak23