Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Optimize bech32 Encoding Performance #119

Closed
wants to merge 2 commits into from
Closed

feat: Optimize bech32 Encoding Performance #119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0306ee9
feat: Optimize bech32 Encoding Performance
May 28, 2024
3d6e492
fix: Optimize bech32 Encoding Performance
May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 11 additions & 28 deletions onchain/src/social/bech32.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ use core::to_byte_array::FormatAsByteArray;
use core::traits::{Into, TryInto};

use joyboy::utils::{shl, shr};

//! bech32 encoding implementation
//! Spec: https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki
//! Sample implementations:
Expand All @@ -22,7 +21,6 @@ fn polymod(values: Array<u8>) -> u32 {
0x3b6a57b2_u32, 0x26508e6d_u32, 0x1ea119fa_u32, 0x3d4233dd_u32, 0x2a1462b3_u32
];
let generator = generator.span();

let mut chk = 1_u32;

let len = values.len();
Expand Down Expand Up @@ -81,46 +79,32 @@ fn convert_bytes_to_5bit_chunks(bytes: @Array<u8>) -> Array<u8> {

let len = bytes.len();
let mut i = 0;

let mut acc = 0_u8;
let mut missing_bits = 5_u8;

// println!("bytes = {bytes:?}");
loop {
if i == len {
break ();
}
while i < len {
let mut byte: u8 = *bytes.at(i);
let mut bits_left = 8_u8;
loop {
while bits_left > 0 {
let chunk_size = min(missing_bits, bits_left);
let chunk = shr(byte, 8 - chunk_size);
// println!(
// "byte: {}, acc: {}, chunk: {} -> {}",
// byte.format_as_byte_array(2),
// acc.format_as_byte_array(2),
// chunk.format_as_byte_array(2),
// (acc + chunk).format_as_byte_array(2)
// );
r.append(acc + chunk);
byte = shl(byte, chunk_size);
bits_left -= chunk_size;
if bits_left < 5 {
acc = shr(byte, 3);
missing_bits = 5 - bits_left;
break ();
break;
} else {
acc = 0;
missing_bits = 5
missing_bits = 5;
}
};
}
i += 1;
};
}
if missing_bits < 5 {
// println!("-> {}", acc.format_as_byte_array(2));
r.append(acc);
}
// println!("r = {r:?}");
r
}

Expand Down Expand Up @@ -162,25 +146,24 @@ fn checksum(hrp: @ByteArray, data: @Array<u8>) -> Array<u8> {
}

pub fn encode(hrp: @ByteArray, data: @ByteArray, limit: usize) -> ByteArray {
// change into an array and a const
let alphabet: ByteArray = "qpzry9x8gf2tvdw0s3jn54khce6mua7l";


const ALPHABET: ByteArray = "qpzry9x8gf2tvdw0s3jn54khce6mua7l";
let data_5bits = convert_bytes_to_5bit_chunks(@data.into());

let cs = checksum(hrp, @data_5bits);

let mut combined = ArrayTrait::new();
combined.append_span(data_5bits.span());
combined.append_span(cs.span());

let mut encoded: ByteArray = Default::default();
encoded.append_byte(b'1');
let mut i = 0;
let len = combined.len();
loop {
if i == len {
break ();
break;
}
encoded.append_byte(alphabet.at((*combined.at(i)).into()).unwrap());
encoded.append_byte(ALPHABET.at((*combined.at(i)).into()).unwrap());
i += 1;
};

Expand Down
Loading