Fix compatibility with setuptools 72 #858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omidkk
approved these changes
Jul 29, 2024
sileht
approved these changes
Jul 29, 2024
matt-genie
approved these changes
Jul 29, 2024
jd
approved these changes
Jul 29, 2024
yabirgb
added a commit
to yabirgb/rotki
that referenced
this pull request
Jul 29, 2024
As documented here pypa/setuptools#4519 setuptools has released a breaking change that removes a functionality used by some our dependencies breaking the install process. In our case is the VCR package that has been already notified kevin1024/vcrpy#858
yabirgb
added a commit
to yabirgb/rotki
that referenced
this pull request
Jul 29, 2024
As documented here pypa/setuptools#4519 setuptools has released a breaking change that removes a functionality used by some our dependencies breaking the install process. In our case is the VCR package that has been already notified kevin1024/vcrpy#858
yabirgb
added a commit
to yabirgb/rotki
that referenced
this pull request
Jul 29, 2024
As documented here pypa/setuptools#4519 setuptools has released a breaking change that removes a functionality used by some our dependencies breaking the install process. In our case is the VCR package that has been already notified kevin1024/vcrpy#858 [run nft py tests]
yabirgb
added a commit
to yabirgb/rotki
that referenced
this pull request
Jul 29, 2024
As documented here pypa/setuptools#4519 setuptools has released a breaking change that removes a functionality used by some our dependencies breaking the install process. In our case is the VCR package that has been already notified kevin1024/vcrpy#858 [run nft py tests]
LefterisJP
pushed a commit
to rotki/rotki
that referenced
this pull request
Jul 29, 2024
As documented here pypa/setuptools#4519 setuptools has released a breaking change that removes a functionality used by some our dependencies breaking the install process. In our case is the VCR package that has been already notified kevin1024/vcrpy#858 [run nft py tests]
|
setuptools got new release that restores tests - https://setuptools.pypa.io/en/stable/history.html#v72-1-0 PR can be closed |
The tests command is still deprecated. |
|
thanks for the PR but I merged #856 instead |
OjusWiZard
pushed a commit
to OjusWiZard/rotki
that referenced
this pull request
Aug 9, 2024
As documented here pypa/setuptools#4519 setuptools has released a breaking change that removes a functionality used by some our dependencies breaking the install process. In our case is the VCR package that has been already notified kevin1024/vcrpy#858 [run nft py tests]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest advises to not integrate with setuptools anymore, thus I've dropped that part.
Solves #855 #854