fix: replace deprecated jax.numpy.trapz #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently in the 0.4.16 JAX release, there were several deprecations following NEP52 (https://numpy.org/neps/nep-0052-python-api-cleanup.html) One of those was jax.numpy.trapz. Instead we are meant to use jax.scipy.integrate.trapozoid. The C. Elegans code used trapz so it is not running on the current version.
Packages requiere newer Python versions than 3.8. But some packages are old and use deprecated features (scikit-video), so I added a quick fix. Ideally I fix it at some point. Some versions on requirements are also more clearly specified, as there are other deprecations.
alonfnt
force-pushed
the
fix_jax_deprecation
branch
from
81098ac
to
16a6c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently in the 0.4.16 JAX release, there were several deprecations following NEP52
(https://numpy.org/neps/nep-0052-python-api-cleanup.html) One of those was jax.numpy.trapz. Instead we are meant to use jax.scipy.integrate.trapozoid.
The C. Elegans code used trapz so it is not running on the current version.