Fix: remove --config option from kubeadm upgrade (#11350)

[tmurakam]

We can't mix some options with --config for kubeadm upgrade. The --config on upgrade (with InitConfiguration/ClusterConfiguration) is deprecated, and should be removed.

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix upgrade issue of kubespray upgrade.
This removes --config option.

Which issue(s) this PR fixes:
Fixes #11350

Special notes for your reviewer:
I have no confidence of side effects of removing the --config options.
Please consider the effects. If it is not acceptable, please reject this PR.

Does this PR introduce a user-facing change?:

Disables reconfiguring the cluster during upgrade (remove --config option from kubeadm upgrade apply)

[k8s-ci-robot]

Hi @tmurakam. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tico88612]

/ok-to-test

[tico88612]

Your PR didn't include that Kubeadm deprecates the --config parameter. I'm attaching a search to find it.

kubernetes/kubeadm#3054
https://github.com/kubernetes/kubernetes/pull/123068/files#diff-657870bffd956e3e3553db7dbb5cb725ea53922da959fcf869c2e31880df72c7L91

However, the documentation I found does not indicate that they are deprecated. For the time being, the v1.30 version can't use the --config parameter, but v1.31 can use UpgradeConfiguration for configuration (only available in apiVersion kubeadm.k8s.io/v1beta4).

related #10935

https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta4/

[tmurakam]

@tico88612
You are right. The v1.31 will be able to use --config for UpgradeConfiguration of v1beta4.
I think using --config for InitConfiguration or ClusterConfiguration for upgrade is deprecated.
Updated the description of this PR.

[MrFreezeex]

In the issue in the kubeadm project it was said this as well:

you should drop your usage of --config on upgrade to 1.30 and 1.31 for non-v1beta4 APIs and use similar actions to reconfigure a kubeadm cluster:
https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-reconfigure/

And I don't think we are applying/editing this cluster wide configmap anywhere which we should be doing if we can't use the local config anymore IIUC

[tmurakam]

@MrFreezeex @cyclinder
Could you please proceed with your review of this?

[tico88612]

@yankay @ant31 Do we have a CI for upgrading the cluster?
If this PR is not handled and 2.26 is released in the future, upgrading the cluster will fail.

[tico88612]

/label ci-extended

[k8s-ci-robot]

@tico88612: The label(s) /label ci-extended cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ci-extended

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

@tico88612: The label(s) /label ci-extended cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ci-extended

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tmurakam]

I created a PR #11458 to add a CI job to test cluster upgrading.

[tico88612]

Manual test successful.

/lgtm

[yankay]

HI @ErikJiang

Would you please help to review it

[yankay]

Thanks @tmurakam
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmurakam, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yankay]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment